Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix dtslint problem #1182

Merged
merged 3 commits into from Jul 28, 2019
Merged

build: fix dtslint problem #1182

merged 3 commits into from Jul 28, 2019

Conversation

splincode
Copy link
Member

@splincode splincode commented Jul 28, 2019 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

Now it is possible to use for type testing the version of TypeScript that is used to build the application.

@splincode splincode requested review from markwhitfeld and arturovt and removed request for markwhitfeld July 28, 2019 15:03
markwhitfeld
markwhitfeld approved these changes Jul 28, 2019
View reviewed changes
Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, amazing, amazing!!!!!!
Well done for finding how to do this!

@markwhitfeld markwhitfeld merged commit 5d28377 into master Jul 28, 2019
@markwhitfeld markwhitfeld deleted the fix/tslint branch July 28, 2019 19:08
@markwhitfeld markwhitfeld added this to the 3.5.x milestone Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwhitfeld markwhitfeld markwhitfeld approved these changes

@arturovt arturovt arturovt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@splincode @markwhitfeld @arturovt