Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router-plugin): revert state back after "RouterCancel" is dispatched #1236

Merged
merged 1 commit into from Aug 17, 2019

Conversation

arturovt
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #542

What is the new behavior?

The state is reverted back

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@arturovt
Copy link
Member Author

arturovt commented Aug 15, 2019

@markwhitfeld @splincode

This is bugfix for the very old #542 issue. Our router plugin doesn't revert state back, if the router emits NavigationCancel event in the current behavior. This is described in the issue and can be reproduced if any route has canDeactivate hook that returns false. The new behavior fixes it and reverts the state back as it has to be.

@arturovt arturovt requested review from splincode and markwhitfeld and removed request for splincode August 15, 2019 17:05
Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Great tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants