feat(selector-utils): add advanced selector utils #1824

Carniatto · 2022-02-10T15:20:28Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/ngxs/store/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1653, #1672

What is the new behavior?

Added some utilities for creating selectors.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

packages/store/tests/property-selectors.spec.ts

markwhitfeld · 2022-12-15T09:21:05Z

@Carniatto I am wanting to get the next minor release out, but would like to include this.
How is it going with the tests?

…ector

bundlemon · 2023-02-24T17:59:08Z

BundleMon

Files updated (1)

Status	Path	Size	Limits
❌	fesm2015/ngxs-store.js	91.76KB (+2.64KB +2.96%)	125KB / +0.5%

Unchanged files (2)

Status	Path	Size	Limits
✅	fesm2015/ngxs-store-operators.js	6.23KB	15KB / +0.5%
✅	fesm2015/ngxs-store-internals.js	4.22KB	20KB / +0.5%

Total files change +2.64KB +2.65%

Groups updated (3)

Status	Path	Size	Limits
❌	@ngxs/store(esm2015)[gzip] _{./esm2015/*/.js}	175.3KB (+8.24KB +4.93%)	+1%
❌	@ngxs/store(umd)[gzip] _{./bundles/*.umd.js}	36.05KB (+723B +2%)	+1%
❌	@ngxs/store(fesm2015)[gzip] _{./fesm2015/*.js}	24.64KB (+613B +2.49%)	+1%

Final result: ❌

View report in BundleMon website ➡️

Current branch size history | Target branch size history

bundlemon · 2023-02-24T17:59:11Z

BundleMon (NGXS Plugins)

Unchanged files (14)

Status	Path	Size	Limits
✅	Plugins(umd)[gzip] _{storage-plugin/bundles/ngxs-storage-plugin.um d.js}	7.96KB	+1%
✅	Plugins(umd)[gzip] _{router-plugin/bundles/ngxs-router-plugin.umd. js}	7.41KB	+1%
✅	Plugins(umd)[gzip] _{websocket-plugin/bundles/ngxs-websocket-plugi n.umd.js}	6.92KB	+1%
✅	Plugins(umd)[gzip] _{hmr-plugin/bundles/ngxs-hmr-plugin.umd.js}	6.89KB	+1%
✅	Plugins(fesm2015)[gzip] _{storage-plugin/fesm2015/ngxs-storage-plugin.j s}	3.64KB	+1%
✅	Plugins(umd)[gzip] _{form-plugin/bundles/ngxs-form-plugin.umd.js}	3.41KB	+1%
✅	Plugins(fesm2015)[gzip] _{router-plugin/fesm2015/ngxs-router-plugin.js}	3.09KB	+1%
✅	Plugins(umd)[gzip] _{devtools-plugin/bundles/ngxs-devtools-plugin. umd.js}	2.75KB	+1%
✅	Plugins(fesm2015)[gzip] _{form-plugin/fesm2015/ngxs-form-plugin.js}	2.65KB	+1%
✅	Plugins(fesm2015)[gzip] _{hmr-plugin/fesm2015/ngxs-hmr-plugin.js}	2.65KB	+1%
✅	Plugins(fesm2015)[gzip] _{websocket-plugin/fesm2015/ngxs-websocket-plug in.js}	2.59KB	+1%
✅	Plugins(umd)[gzip] _{logger-plugin/bundles/ngxs-logger-plugin.umd. js}	2.53KB	+1%
✅	Plugins(fesm2015)[gzip] _{devtools-plugin/fesm2015/ngxs-devtools-plugin .js}	2.17KB	+1%
✅	Plugins(fesm2015)[gzip] _{logger-plugin/fesm2015/ngxs-logger-plugin.js}	2.01KB	+1%

No change in files bundle size

Unchanged groups (3)

Status	Path	Size	Limits
✅	All Plugins(esm2015)[gzip] _{./-plugin/esm2015/**/.js}	108.59KB	+1%
✅	All Plugins(umd)[gzip] _{./-plugin/bundles/.umd.js}	37.88KB	+1%
✅	All Plugins(fesm2015)[gzip] _{./-plugin/fesm2015/.js}	18.8KB	+1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

bundlemon · 2023-02-24T17:59:14Z

BundleMon (Integration Projects)

Files updated (1)

Status	Path	Size	Limits
✅	Main bundles(Gzip) _{hello-world-ng14-ivy/dist-integration/main.(h ash).js}	65.47KB (+11B +0.02%)	+1%

Unchanged files (2)

Status	Path	Size	Limits
✅	Main bundles(Gzip) _{hello-world-ng13-ivy/dist-integration/main.(h ash).js}	69.79KB	+1%
✅	Main bundles(Gzip) _{hello-world-ng12-ivy/dist-integration/main.(h ash).js}	67.95KB	+1%

Total files change +10B 0%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

arturovt

We've been already using this implementation in production for the last ~2 years. I don't have anything to review here since it's obvious and clear.

Carniatto · 2023-03-01T14:34:17Z

We've been already using this implementation in production for the last ~2 years. I don't have anything to review here since it's obvious and clear.

Same for me 💗

docs/advanced/selector-utils.md

packages/store/tests/selectors/create-model-selector.spec.ts

codeclimate · 2023-03-09T12:43:17Z

Code Climate has analyzed commit 4f33f91 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 97.0% (0.0% change).

View more on Code Climate.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@ngxs/form-plugin](https://github.com/ngxs/store) | dependencies | minor | [`3.7.6` -> `3.8.0`](https://renovatebot.com/diffs/npm/@ngxs%2fform-plugin/3.7.6/3.8.0) | | [@ngxs/storage-plugin](https://github.com/ngxs/store) | dependencies | minor | [`3.7.6` -> `3.8.0`](https://renovatebot.com/diffs/npm/@ngxs%2fstorage-plugin/3.7.6/3.8.0) | | [@ngxs/store](https://github.com/ngxs/store) | dependencies | minor | [`3.7.6` -> `3.8.0`](https://renovatebot.com/diffs/npm/@ngxs%2fstore/3.7.6/3.8.0) | --- ### Release Notes <details> <summary>ngxs/store</summary> ### [`v3.8.0`](https://github.com/ngxs/store/blob/HEAD/CHANGELOG.md#380-2023-03-29) [Compare Source](ngxs/store@v3.7.6...v3.8.0) - Feature: Build packages in Ivy format [#1945](ngxs/store#1945) - Feature: Add advanced selector utilities [#1824](ngxs/store#1824) - Feature: Expose `ActionContext` and `ActionStatus` [#1766](ngxs/store#1766) - Feature: `ofAction*` methods should have strong types [#1808](ngxs/store#1808) - Feature: Improve contextual type inference for state operators [#1806](ngxs/store#1806) [#1947](ngxs/store#1947) - Feature: Enable warning on unhandled actions [#1870](ngxs/store#1870) [#1951](ngxs/store#1951) - Feature: Router Plugin - Provide more actions and navigation timing option [#1932](ngxs/store#1932) - Feature: Storage Plugin - Allow providing namespace for keys [#1841](ngxs/store#1841) - Feature: Storage Plugin - Enable providing storage engine individually [#1935](ngxs/store#1935) - Feature: Devtools Plugin - Add new options to the `NgxsDevtoolsOptions` interface [#1879](ngxs/store#1879) - Feature: Devtools Plugin - Add trace options to `NgxsDevtoolsOptions` [#1968](ngxs/store#1968) - Feature: Form Plugin - Allow `ngxsFormDebounce` to be string [#1972](ngxs/store#1972) - Performance: Tree-shake patch errors [#1955](ngxs/store#1955) - Fix: Get descriptor explicitly when it's considered as a class property [#1961](ngxs/store#1961) - Fix: Avoid delayed updates from state stream [#1981](ngxs/store#1981) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1837 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

feat(selector-utils): Impl. selector utils

cf7b8d9

markwhitfeld approved these changes Feb 10, 2022

View reviewed changes

markwhitfeld requested changes Feb 10, 2022

View reviewed changes

packages/store/tests/property-selectors.spec.ts Outdated Show resolved Hide resolved

Carniatto force-pushed the selector-utils branch from 63de013 to b79f8fc Compare December 9, 2022 15:00

test(selector-utils): Initial unit tests

ab53b4d

Carniatto force-pushed the selector-utils branch from b79f8fc to ab53b4d Compare December 20, 2022 12:14

carniatto and others added 2 commits January 12, 2023 09:36

refactor(select-utils): Rename createMappedSelector to createModelSel…

d2e65b7

…ector

Merge remote-tracking branch 'origin/master' into selector-utils

69cfdb9

markwhitfeld added 12 commits February 24, 2023 20:17

docs: fix selector util code examples

029ed13

docs: fix description of pick selector

2987483

docs: add note about performance benefit of pick selector

4f62980

docs: add index to sections for selector utils

53baa2e

refactor(store): rename selector util files

11626eb

refactor(store): fix internal type references

a8a879f

feat(store): export selector utils in public api

43931d8

test(store): move selector util spec files

3d029f1

chore(store): add error handling to createPropertySelectors

ecb7381

test(store): clean up createPropertySelectors tests

22923be

test: remove the .only usage in test

1f4f57b

test(store): add more createPropertySelectors tests

8212ac9

markwhitfeld marked this pull request as ready for review February 24, 2023 22:32

markwhitfeld requested review from arturovt, kuncevic, poloagustin, joaqcid and splincode as code owners February 24, 2023 22:32

markwhitfeld added 2 commits February 25, 2023 00:38

test(store): fix issue in createPropertySelectors tests

21b5fed

test(store): add some createPickSelector tests

5416dac

Carniatto requested a review from markwhitfeld February 28, 2023 12:24

joaqcid approved these changes Feb 28, 2023

View reviewed changes

arturovt approved these changes Mar 1, 2023

View reviewed changes

markwhitfeld added 8 commits March 3, 2023 21:36

test(store): add more createPickSelector tests

7fdd468

docs: more docs improvements

1d40487

test: fix broken test snapshots

78cefbf

test(store): add tests for createModelSelector

c9620e8

refactor: extract checks for selector map

3958bfb

docs: more docs improvements

5de5409

chore: update CHANGELOG.md

ff69ba3

chore: update CHANGELOG.md

f743908

markwhitfeld approved these changes Mar 9, 2023

View reviewed changes

markwhitfeld changed the title ~~feat(selector-utils): Impl. selector utils~~ feat(selector-utils): add advanced selector utils Mar 9, 2023

markwhitfeld mentioned this pull request Mar 9, 2023

🚀[FEATURE]: Provide state slices as selectors out-of-the-box #1653

Closed

markwhitfeld added this to the v3.next-minor milestone Mar 9, 2023

markwhitfeld added the type: feature label Mar 9, 2023

Carniatto commented Mar 9, 2023

View reviewed changes

docs/advanced/selector-utils.md Outdated Show resolved Hide resolved

Carniatto commented Mar 9, 2023

View reviewed changes

packages/store/tests/selectors/create-model-selector.spec.ts Show resolved Hide resolved

docs(store): fix issue

4f33f91

markwhitfeld merged commit 81a817d into ngxs:master Mar 9, 2023

markwhitfeld modified the milestones: v3.next-minor, v3.8.0 Mar 29, 2023

markwhitfeld added the released label Mar 29, 2023

abdulrahman305 mentioned this pull request Jul 3, 2024

[Snyk] Upgrade: , , , , abdulrahman305/auptimizer#4

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(selector-utils): add advanced selector utils #1824

feat(selector-utils): add advanced selector utils #1824

Carniatto commented Feb 10, 2022 •

edited by markwhitfeld

Loading

markwhitfeld commented Dec 15, 2022

bundlemon bot commented Feb 24, 2023 •

edited

Loading

bundlemon bot commented Feb 24, 2023 •

edited

Loading

bundlemon bot commented Feb 24, 2023 •

edited

Loading

arturovt left a comment

Carniatto commented Mar 1, 2023

codeclimate bot commented Mar 9, 2023

feat(selector-utils): add advanced selector utils #1824

feat(selector-utils): add advanced selector utils #1824

Conversation

Carniatto commented Feb 10, 2022 • edited by markwhitfeld Loading

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

markwhitfeld commented Dec 15, 2022

bundlemon bot commented Feb 24, 2023 • edited Loading

BundleMon

bundlemon bot commented Feb 24, 2023 • edited Loading

BundleMon (NGXS Plugins)

bundlemon bot commented Feb 24, 2023 • edited Loading

BundleMon (Integration Projects)

arturovt left a comment

Choose a reason for hiding this comment

Carniatto commented Mar 1, 2023

codeclimate bot commented Mar 9, 2023

Carniatto commented Feb 10, 2022 •

edited by markwhitfeld

Loading

bundlemon bot commented Feb 24, 2023 •

edited

Loading

bundlemon bot commented Feb 24, 2023 •

edited

Loading

bundlemon bot commented Feb 24, 2023 •

edited

Loading