-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to nx #1992
chore: migrate to nx #1992
Conversation
BundleMonFiles updated (1)
Unchanged files (2)
Total files change -383B -0.36% Groups updated (3)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Unchanged files (14)
No change in files bundle size Unchanged groups (3)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Unchanged files (3)
Total files change -1B 0% Final result: ✅ View report in BundleMon website ➡️ |
a870d35
to
7784432
Compare
7784432
to
0bb802a
Compare
Code Climate has analyzed commit 0bb802a and detected 8 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (-0.3% change). View more on Code Climate. |
Oooooh. Fantastic!!!!!! |
@dmitry-stepanenko with this PR being in draft, what is outstanding before it is ready for review? |
@markwhitfeld I guess it can be reviewed at this point. One thing I could not verify is unit test reports: after migration to nx each package has own report, all of those reports are now being merged before uploading, I was able to verify codeclimate binary creates merged report file, but it's also needed to ensure it is correct in their system after uploading. Also please claim the ownership of the generated Nx Cloud key from nx.json. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work! Thank you so much!!!!
Ok, I have claimed the NX token. |
Awesome! Thanks for merging 🙂 |
Migrating the workspace to nx:
store
will be built before plugins,integration
app will require all packages to be build beforehand)