Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(*): replace get type() with type = in actions #2035

Merged
merged 1 commit into from Jul 23, 2023

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Jul 15, 2023

This commit replaces type getters with property declarations like
static type = '...'. The get type() was required a long time ago
to maintain backward compatibility between TypeScript 2 and 3 versions.
However, this is no longer necessary.

@nx-cloud
Copy link

nx-cloud bot commented Jul 15, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 86df8cd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@bundlemon
Copy link

bundlemon bot commented Jul 15, 2023

BundleMon

Files updated (1)
Status Path Size Limits
fesm2015/ngxs-store.js
94.14KB (-340B -0.35%) 125KB / +0.5%
Unchanged files (2)
Status Path Size Limits
fesm2015/ngxs-store-operators.js
6.23KB 15KB / +0.5%
fesm2015/ngxs-store-internals.js
3.57KB 20KB / +0.5%

Total files change -340B -0.32%

Groups updated (3)
Status Path Size Limits
@ngxs/store(fesm2015)[gzip]
./fesm2015/*.js
24.95KB (-80B -0.31%) +1%
@ngxs/store(umd)[gzip]
./bundles/*.umd.js
36.45KB (-104B -0.28%) +1%
@ngxs/store(esm2015)[gzip]
./esm2015/**/*.js
179.87KB (-402B -0.22%) +1%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Jul 15, 2023

BundleMon (NGXS Plugins)

Files updated (6)
Status Path Size Limits
Plugins(fesm2015)[gzip]
websocket-plugin/fesm2015/ngxs-websocket-plug
in.js
2.52KB (-72B -2.71%) +1%
Plugins(fesm2015)[gzip]
router-plugin/fesm2015/ngxs-router-plugin.js
3KB (-94B -2.97%) +1%
Plugins(fesm2015)[gzip]
form-plugin/fesm2015/ngxs-form-plugin.js
2.57KB (-102B -3.73%) +1%
Plugins(umd)[gzip]
websocket-plugin/bundles/ngxs-websocket-plugi
n.umd.js
6.79KB (-137B -1.93%) +1%
Plugins(umd)[gzip]
form-plugin/bundles/ngxs-form-plugin.umd.js
3.29KB (-152B -4.32%) +1%
Plugins(umd)[gzip]
router-plugin/bundles/ngxs-router-plugin.umd.
js
7.26KB (-158B -2.08%) +1%
Unchanged files (8)
Status Path Size Limits
Plugins(umd)[gzip]
storage-plugin/bundles/ngxs-storage-plugin.um
d.js
7.97KB +1%
Plugins(umd)[gzip]
hmr-plugin/bundles/ngxs-hmr-plugin.umd.js
6.89KB +1%
Plugins(fesm2015)[gzip]
storage-plugin/fesm2015/ngxs-storage-plugin.j
s
3.7KB +1%
Plugins(umd)[gzip]
devtools-plugin/bundles/ngxs-devtools-plugin.
umd.js
2.75KB +1%
Plugins(fesm2015)[gzip]
hmr-plugin/fesm2015/ngxs-hmr-plugin.js
2.65KB +1%
Plugins(umd)[gzip]
logger-plugin/bundles/ngxs-logger-plugin.umd.
js
2.53KB +1%
Plugins(fesm2015)[gzip]
devtools-plugin/fesm2015/ngxs-devtools-plugin
.js
2.17KB +1%
Plugins(fesm2015)[gzip]
logger-plugin/fesm2015/ngxs-logger-plugin.js
2.01KB +1%

Total files change -715B -1.23%

Groups updated (3)
Status Path Size Limits
All Plugins(fesm2015)[gzip]
./-plugin/fesm2015/.js
18.62KB (-268B -1.39%) +1%
All Plugins(umd)[gzip]
./-plugin/bundles/.umd.js
37.48KB (-447B -1.15%) +1%
All Plugins(esm2015)[gzip]
./-plugin/esm2015/**/.js
108.03KB (-1.46KB -1.34%) +1%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Jul 15, 2023

BundleMon (Integration Projects)

Files updated (3)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng13-ivy/dist-integration/main.(h
ash).js
69.87KB (+32B +0.04%) +1%
Main bundles(Gzip)
hello-world-ng12-ivy/dist-integration/main.(h
ash).js
68KB (+28B +0.04%) +1%
Main bundles(Gzip)
hello-world-ng14-ivy/dist-integration/main.(h
ash).js
64.84KB (+17B +0.03%) +1%

Total files change +77B +0.04%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

This commit replaces type getters with property declarations like
`static type = '...'`. The `get type()` was required a long time ago
to maintain backward compatibility between TypeScript 2 and 3 versions.
However, this is no longer necessary.
@codeclimate
Copy link

codeclimate bot commented Jul 23, 2023

Code Climate has analyzed commit 86df8cd and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 5

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 96.6% (-0.1% change).

View more on Code Climate.

@markwhitfeld markwhitfeld merged commit 2d37dd5 into master Jul 23, 2023
18 checks passed
@markwhitfeld markwhitfeld deleted the refactor/types branch July 23, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants