New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(*): replace get type()
with type =
in actions
#2035
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 86df8cd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
BundleMonFiles updated (1)
Unchanged files (2)
Total files change -340B -0.32% Groups updated (3)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Files updated (6)
Unchanged files (8)
Total files change -715B -1.23% Groups updated (3)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files updated (3)
Total files change +77B +0.04% Final result: ✅ View report in BundleMon website ➡️ |
This commit replaces type getters with property declarations like `static type = '...'`. The `get type()` was required a long time ago to maintain backward compatibility between TypeScript 2 and 3 versions. However, this is no longer necessary.
Code Climate has analyzed commit 86df8cd and detected 5 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 96.6% (-0.1% change). View more on Code Climate. |
This commit replaces type getters with property declarations like
static type = '...'
. Theget type()
was required a long time agoto maintain backward compatibility between TypeScript 2 and 3 versions.
However, this is no longer necessary.