Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(store): rely on ngDevMode to be always defined #2138

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

arturovt
Copy link
Member

This commit updates all ngDevMode conditions to remove the check for ngDevMode being undefined. We can ensure it's always defined by Angular since VE has been dropped. However, the typeof check is still necessary to ensure code safety, as ngDevMode is a global variable provided by the framework.

This commit updates all `ngDevMode` conditions to remove the check for `ngDevMode`
being `undefined`. We can ensure it's always defined by Angular since VE has been
dropped. However, the `typeof` check is still necessary to ensure code safety,
as `ngDevMode` is a global variable provided by the framework.
Copy link

nx-cloud bot commented Mar 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6bbdf0d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

Copy link

bundlemon bot commented Mar 21, 2024

BundleMon (Integration Projects)

Files updated (1)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
66.94KB (+17B +0.02%) +1%
Unchanged files (1)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
68.43KB +1%

Total files change +11B +0.01%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codeclimate bot commented Mar 21, 2024

Code Climate has analyzed commit 6bbdf0d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (0.0% change).

View more on Code Climate.

@arturovt arturovt merged commit 9e80885 into master Mar 22, 2024
12 checks passed
@arturovt arturovt deleted the refactor/dev-mode branch March 22, 2024 06:45
@markwhitfeld markwhitfeld added this to the v.18.0.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants