Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): created maps properties should be enumerable #2150

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

arturovt
Copy link
Member

No description provided.

Copy link

nx-cloud bot commented Mar 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 20afafa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

Copy link

bundlemon bot commented Mar 29, 2024

BundleMon (Integration Projects)

Unchanged files (2)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
68.48KB +1%
Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
67.03KB +1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codeclimate bot commented Mar 29, 2024

Code Climate has analyzed commit 20afafa and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.2% (0.4% change).

View more on Code Climate.

@arturovt arturovt merged commit 14c1707 into master Mar 29, 2024
12 checks passed
@arturovt arturovt deleted the fix/enumerable branch March 29, 2024 21:09
Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I had actually written a comment about this in the other PR, but didn't submit my review 😬

@markwhitfeld markwhitfeld added this to the v.18.0.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants