Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): deprecating registry.yarnpkg.com #613

Merged
merged 1 commit into from
Oct 21, 2018

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

yarnpkg/yarn#5891

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

unused package was removed ("rxjs-compat": "^6.0.0")

https://update.angular.io/
Remove deprecated RxJS 6 features using rxjs-tslint auto update rules
For most applications this will mean running the following two commands:

yarn global add rxjs-tslint
rxjs-5-to-6-migrate -p src/tsconfig.app.json

Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markwhitfeld
Copy link
Member

From your instructions in the other Information section are there any breaking changes for our users? Or is it just for people building the lib?

@splincode
Copy link
Member Author

splincode commented Oct 21, 2018

@markwhitfeld no breaking changes because this library was a bridge to the outdated RxJS 5

image

@splincode splincode merged commit 051df4c into ngxs:master Oct 21, 2018
@splincode splincode deleted the fix/npm-registry branch October 25, 2018 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants