Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(store): add docs about state operators #799

Merged
merged 5 commits into from
Feb 2, 2019
Merged

docs(store): add docs about state operators #799

merged 5 commits into from
Feb 2, 2019

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Jan 27, 2019

PR Checklist

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

#786

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@arturovt arturovt requested a review from deebloo January 27, 2019 19:22
Copy link
Member

@eranshmil eranshmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add a link to this new page. :)

Edit: And maybe add links to Mark's medium post and the main issue.

docs/advanced/operators.md Outdated Show resolved Hide resolved
docs/advanced/operators.md Outdated Show resolved Hide resolved
docs/advanced/operators.md Show resolved Hide resolved
@arturovt
Copy link
Member Author

arturovt commented Jan 29, 2019

@markwhitfeld @deebloo gentlemen

docs/advanced/operators.md Show resolved Hide resolved
docs/advanced/operators.md Outdated Show resolved Hide resolved
@arturovt
Copy link
Member Author

@markwhitfeld @eranshmil @splincode updated

docs/advanced/operators.md Outdated Show resolved Hide resolved
Copy link
Member

@eranshmil eranshmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add the example back as discussed in the comments.

Edit: And add the link in the docs menu.

@arturovt
Copy link
Member Author

arturovt commented Jan 30, 2019

@eranshmil Sure, I've just missunderstood, should I replace patch with:

const state = ctx.getState();

ctx.setState(state => ({
  ...state,
  monkeys: []
}));

@markwhitfeld
Copy link
Member

const state = ctx.getState();
ctx.setState({
  ...state,
  monkeys: []
});

@markwhitfeld
Copy link
Member

Please also add a link to this page as the first item under the advanced menu section. You can label it "State Operators".

@arturovt
Copy link
Member Author

arturovt commented Feb 1, 2019

@markwhitfeld 🚀

@markwhitfeld markwhitfeld merged commit eaca271 into ngxs:master Feb 2, 2019
@markwhitfeld
Copy link
Member

Sorry for the delay. It's been a busy few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants