Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): remove typings that are incompatible with TS 2.7 #853

Merged

Conversation

markwhitfeld
Copy link
Member

@markwhitfeld markwhitfeld commented Feb 18, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Client project build fails when using Angular 5/6 with TS 2.7.

What is the new behavior?

The build does not fail because I removed the incompatible typings.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@markwhitfeld markwhitfeld marked this pull request as ready for review February 18, 2019 20:01
@markwhitfeld
Copy link
Member Author

Not sure if this is all of them, but these are the ones I found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants