Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve controller/injectable patterns #56

Merged
merged 5 commits into from
Nov 26, 2023

Conversation

elcharitas
Copy link
Member

This PR handles some long standing issues with how ngyn treats controllers and injectables and introduces the following

  • controller route methods are now required to borrow self rather than refrencing.
  • less footprint with one single trait for both controllers and injectables
  • slightly improved performance with middleware
  • middlewares now receive a mutable response which follows suit with ngyn's principles in that responses should be mutable while requests shouldn't

Copy link

cocogitto-bot bot commented Nov 26, 2023

✔️ 6f1f87f...a770b7b - Conventional commits check succeeded.

@elcharitas elcharitas merged commit c0314bc into dev Nov 26, 2023
2 of 4 checks passed
@elcharitas elcharitas deleted the fix/improve-controller/injectable-patterns branch November 26, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant