NH-3272 - Move TypeHelperExtensionMethods to a more internal namespace

[mahara]

Description here: https://nhibernate.jira.com/browse/NH-3272

[oskarb]

Aah... what a peculiar little class you've found. I'm thinking that it may not belong under NHibernate.Linq at all, plus more:

• Most methods operator on System.Type, so it should really be called TypeExtensionMethods to follow the general pattern, and be in NHibernate.Util, since it hasn't really got anything to do with LINQ.
• Two methods are out-of-place (i.e. have nothing to do with SystemType):
  • ForEach(), (which happens to be completely unused) fits better in Util/EnumerableExtensions.cs.
  • As(), should be named Cast() as it has different semantics compared to the "as" keyword. But it's only used in 6 places, so I would prefer to remove it completely and use normal casts where needed.

It would be much appreciated if you could adapt the patch according to the above.

[mahara]

OK, done.

[oskarb]

Thanks!