Skip Topological sorting if not required #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm. It seems there is no need to split dependent alias calculation and sorting across different methods. I'm going to remove |
hazzik
reviewed
Feb 7, 2019
hazzik
reviewed
Feb 7, 2019
|
Can you also review #419? |
|
Regarding #419. I know why and what this sorting does. But I have no idea how :) So I can't really say if it's any better than existing algorithm. |
This comment has been minimized.
This comment has been minimized.
…reduce allocations
hazzik
approved these changes
Feb 17, 2019
fredericDelaporte
approved these changes
Feb 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.