NH-3777: Replaced NHibernate.Loader.TopologicalSorter by a more performant impl... #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TAkkerman
changed the title
|
Well, it seems that the topological sort itself was alright, but there must be more restrictions on the order than those that are exposed to the sort algorithm. Will try to update to a variant that matches to the order the old algorithm produces when there are multiple valid solutions. |
|
Hi @TAkkerman, can you please enable Allow edits from maintainers feature? |
|
'allow edits from maintainers' should be active now. |
added 2 commits
February 13, 2017 23:29
…rmant implementation. - Because of a slight change in the (internal) Interface of TopologicalSorter, JoinWalker had to be adjusted (note that the removed parameter i was identical to the return value for the current use of the sorter)
…ological sort. Before, the only constraints exposed to the topological sort where constraints that were found in the explicit "On"-SqlString of the underlying OuterJoinableAssociation and not the implicit dependency of the join itself (LHS depends on RHS)
|
@TAkkerman I've force pushed with rebase on top of master. I've cleaned up indents & namings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ementation.