Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINQ Nullable in WHERE condition tests #3158

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

krzkowal
Copy link
Contributor

@krzkowal krzkowal commented Sep 12, 2022

Test cases for #3156


Assert.DoesNotThrow(
() => _ = session.Query<Role>()
.Where(r => !isActive.HasValue || r.IsActive == isActive.Value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessing .Value on a null parameter remains unsupported, but that is not a regression. And it is a minimal priority issue in my opinion, since this .Value access is not needed and has not any advantage as far as I know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants