Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArgumentException : Column 'SQL_TYPE_NAME' does not belong to table DataTypes (#3438) #3439

Closed
wants to merge 3 commits into from

Conversation

shessane
Copy link

Fix for #3438

Data types will be included in the DB2 reserved words, only if a a column existes with the name "SQL_TYPE_NAME". If not il will not throw an ArgumentException : Column 'SQL_TYPE_NAME' does not belong to table DataTypes.

This PR includes only the uncaught exception. But if you are ok I can add a fallback to the TypeName column if the first does not exist.

@shessane shessane marked this pull request as ready for review October 25, 2023 17:44
@bahusoid bahusoid requested a review from hazzik November 24, 2023 08:01
hazzik
hazzik previously approved these changes Nov 24, 2023
@fredericDelaporte fredericDelaporte added this to the 5.5 milestone Nov 25, 2023
@fredericDelaporte
Copy link
Member

This is fixing a regression introduced in 5.3 by #2058.

Shouldn't we re-target this on the 5.3.x branch?

@fredericDelaporte fredericDelaporte removed this from the 5.5 milestone Nov 25, 2023
@bahusoid
Copy link
Member

Shouldn't we re-target this on the 5.3.x branch?

Up to you. Should we also re-target mysql appveyour fix?

@fredericDelaporte
Copy link
Member

It would be required, unless overlooking its failure on that branch.

@hazzik hazzik dismissed their stale review November 27, 2023 10:47

No longer think it is right changes

@hazzik
Copy link
Member

hazzik commented Nov 27, 2023

This fix is not entirely correct. DB2400Dialect should use own metadata and not trying to add some fallbacks to a sister-dialect's metadata.

@shessane
Copy link
Author

shessane commented Nov 27, 2023

Agree, but since the DB2AS400 inherit the implementation, I thought this was the simplest fix without breaking the logic.

I can cancel the PR, up to you

Edit : I will propose a better implementation with inherited DB2AS400Dialect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants