-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DB2/400 schema generation on 5.3.x #3451
Fix DB2/400 schema generation on 5.3.x #3451
Conversation
c5463b3
to
fb5fd49
Compare
Why new PR? You can rebase existing PR on to 5.3.x branch with:
|
To avoid force pushing on the initial contributor remote. Many are confused by forced pushes. |
This comment was marked as outdated.
This comment was marked as outdated.
Please see my comments here: #3439 (comment) and here: #3438 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should either:
- Restore previous behavior for
DB2400Dialect
, eg, throwingNotSupportedException
; - Implement proper metadata for
DB2400Dialect
; - Do nothing, and abandon this PR advising user to check the configuration, eg setting
hbm2ddl.keywords
tonone
or removing it altogether.
I hope you will go with the solution : Implement proper metadata for DB2400Dialect. It would be sad not to take advantage of the advantages of the new implem just because of a column name. Let me share with you a better implementation. |
We need to fix regression in 5.3.x branch and the safest way to go here is to restore 5.2.x behavior for DB2400Dialect. Proper metadata handling can be added to master branch later. Feel free to provide PR with proper metadata handling. |
Fix the regression on 5.3.x, without adding proper support for DB2400 metadata Fix nhibernate#3438
f2f3a21
to
054db48
Compare
The async regen fails due to these NuGet warnings treated as error, NU190x. |
Try to fix async regen fail
Add /p:TreatWarningsAsErrors=false to restore
genarateasync yml doesn't see unmerged changes but it works. Tested in my branch: https://github.com/bahusoid/nhibernate-core/actions/runs/7014939230 |
Fix #3438
Replace #3439.
That the commits from there, cherry-picked on 5.3.x with another one from #3450 allowing building 5.3.x.