Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DB2/400 schema generation on 5.3.x #3451

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

fredericDelaporte
Copy link
Member

Fix #3438

Replace #3439.

That the commits from there, cherry-picked on 5.3.x with another one from #3450 allowing building 5.3.x.

@bahusoid
Copy link
Member

bahusoid commented Nov 26, 2023

Why new PR?

You can rebase existing PR on to 5.3.x branch with:

git rebase  --onto upstream/5.3.x upstream/master

@fredericDelaporte
Copy link
Member Author

fredericDelaporte commented Nov 26, 2023

To avoid force pushing on the initial contributor remote. Many are confused by forced pushes.
And also, to have the choice between targeting master or 5.3.x by leaving intact the branch based on master.

@bahusoid

This comment was marked as outdated.

@hazzik
Copy link
Member

hazzik commented Nov 27, 2023

Please see my comments here: #3439 (comment) and here: #3438 (comment)

Copy link
Member

@hazzik hazzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should either:

  • Restore previous behavior for DB2400Dialect, eg, throwing NotSupportedException;
  • Implement proper metadata for DB2400Dialect;
  • Do nothing, and abandon this PR advising user to check the configuration, eg setting hbm2ddl.keywords to none or removing it altogether.

@shessane
Copy link

I hope you will go with the solution : Implement proper metadata for DB2400Dialect.

It would be sad not to take advantage of the advantages of the new implem just because of a column name. Let me share with you a better implementation.

@bahusoid
Copy link
Member

bahusoid commented Nov 27, 2023

I hope you will go with the solution : Implement proper metadata for DB2400Dialect.

We need to fix regression in 5.3.x branch and the safest way to go here is to restore 5.2.x behavior for DB2400Dialect. Proper metadata handling can be added to master branch later. Feel free to provide PR with proper metadata handling.

@bahusoid bahusoid changed the title Fix DB2 schema generation on 5.3.x Fix DB2/400 schema generation on 5.3.x Nov 27, 2023
Fix the regression on 5.3.x, without adding proper support for DB2400 metadata

Fix nhibernate#3438
@fredericDelaporte
Copy link
Member Author

The async regen fails due to these NuGet warnings treated as error, NU190x.

Try to fix async regen fail
@bahusoid bahusoid closed this Nov 28, 2023
@bahusoid bahusoid reopened this Nov 28, 2023
Add /p:TreatWarningsAsErrors=false to restore
@bahusoid
Copy link
Member

genarateasync yml doesn't see unmerged changes but it works. Tested in my branch: https://github.com/bahusoid/nhibernate-core/actions/runs/7014939230

@fredericDelaporte fredericDelaporte merged commit f3031ae into nhibernate:5.3.x Nov 28, 2023
15 of 19 checks passed
@fredericDelaporte fredericDelaporte deleted the db2-schema branch November 28, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DB2/400: ArgumentException Column 'SQL_TYPE_NAME' does not belong to table DataTypes
4 participants