Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

fix: change package.json (tui-release-notes address change) / 'template' option add to optionsProps #42

Merged
merged 3 commits into from
Dec 14, 2020

Conversation

awer000
Copy link
Contributor

@awer000 awer000 commented Dec 7, 2020

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@awer000
Copy link
Contributor Author

awer000 commented Dec 7, 2020

The address "https://github.com/nhn/tui.release-notes.git" is now 404. Then I changed new address "https://github.com/nhn/toast-ui.release-notes.git"

@awer000 awer000 changed the title fix: change package.json (tui-release-notes address change) fix: change package.json (tui-release-notes address change) / 'template' option add to optionsProps Dec 7, 2020
@jungeun-cho
Copy link
Contributor

@awer000
Please do not commit the yarn.lock file.
I will upload the installation version management to the package-lock.json file.

@awer000
Copy link
Contributor Author

awer000 commented Dec 11, 2020

@jungeun-cho
Thank you for your comment. I removed yarn.lock file.

Copy link
Contributor

@jungeun-cho jungeun-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@jungeun-cho jungeun-cho merged commit 6e0f927 into nhn:master Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants