Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

How can I use exts with Viewer? #16

Closed
rodumani opened this issue Mar 20, 2019 · 3 comments · Fixed by #17
Closed

How can I use exts with Viewer? #16

rodumani opened this issue Mar 20, 2019 · 3 comments · Fixed by #17
Labels
bug Something isn't working

Comments

@rodumani
Copy link
Contributor

Version

@toast-ui/vue-editor 1.0.4
tui-editor 1.3.3

Test Environment

Chrome 73.0.3683.75

Current Behavior

Editor has options prop, but Viewer does not have options prop so that I cannot define exts to use on Viewer.

Expected Behavior

Please add options prop or exts prop to Viewer
@sohee-lee7 sohee-lee7 added the bug Something isn't working label Mar 20, 2019
@sohee-lee7
Copy link
Contributor

@rodumani I'm sorry I didn't add an extension option to the viewer. This issue will be fixed as soon as possible.

@rodumani
Copy link
Contributor Author

I was trying to fix it by myself to contribute as PR.

However, it's not working because of tui-editor's Viewer's issue which cannot use extension. nhn/tui.editor#414

@sohee-lee7
Copy link
Contributor

@rodumani We should highly praise your efforts. As you mentioned, there is an issue in Viewer. So first of all, I'll release the extension to work in the Viewer soon. Please wait a little longer.

@sohee-lee7 sohee-lee7 mentioned this issue Mar 25, 2019
Merged
6 tasks
sohee-lee7 added a commit that referenced this issue Mar 27, 2019
@sohee-lee7
Merge pull request #17 from nhnent/fix/viewer-ext
222f287 
fix: missing exts option and invoke method in the Viewer (close: #16)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: missing exts option and invoke method in the Viewer (close: #16) nhn/toast-ui.vue-editor
2 participants
@rodumani @sohee-lee7