Skip to content

Commit

Permalink
refactor: Add the eslint (close #1)
Browse files Browse the repository at this point in the history 
Used --fix option.
Add '!==' operation into 'fi' helper function.
Thanks to eslint for finding this bug
  • Loading branch information
Dongsik Yoo committed Feb 13, 2018
1 parent b799eb3 commit b8999b7
Show file tree
Hide file tree
Showing 60 changed files with 997 additions and 347 deletions.
202 changes: 1 addition & 201 deletions .eslintrc
View file
Original file line number Diff line number Diff line change
@@ -1,203 +1,3 @@
{
"env": {
"browser": true,
"amd": true,
"node": true,
"jasmine": true,
"jquery": true
},
"globals": {
"tui": true,
"fixture": true,
"ActiveXObject": true
},
"rules": {
//Possible Errors
"comma-dangle": [2, "never"],
"no-cond-assign": [2, "always"],
"no-console": 1,
"no-constant-condition": 2,
"no-control-regex": 2,
"no-debugger": 1,
"no-dupe-args": 2,
"no-dupe-keys": 2,
"no-duplicate-case": 2,
"no-empty-character-class": 2,
"no-empty": 2,
"no-ex-assign": 2,
"no-extra-boolean-cast": 2,
"no-extra-parens": [2, "functions"],
"no-extra-semi": 2,
"no-func-assign": 2,
"no-inner-declarations": [2, "both"],
"no-invalid-regexp": 2,
"no-irregular-whitespace": 0,
"no-negated-in-lhs": 2,
"no-obj-calls": 2,
"no-regex-spaces": 2,
"no-sparse-arrays": 2,
"no-unexpected-multiline": 2,
"no-unreachable": 2,
"use-isnan": 2,
"valid-jsdoc": [2, {
"prefer": {
"return": "returns"
},
"requireReturnDescription": false,
"requireReturn": false
}],
"valid-typeof": 2,

//Best Practices
"accessor-pairs": [2, {"getWithoutSet": true}],
"block-scoped-var": 2,
"complexity": [1, 6],
"consistent-return": 0,
"curly": 2,
"default-case": 2,
"dot-location": [2, "property"],
"dot-notation": [2, {"allowKeywords": false}],
"eqeqeq": 2,
"guard-for-in": 2,
"no-alert": 0,
"no-caller": 2,
"no-case-declarations": 2,
"no-div-regex": 2,
"no-else-return": 2,
"no-empty-pattern": 2,
"no-eq-null": 2,
"no-eval": 2,
"no-extend-native": 2,
"no-extra-bind": 2,
"no-fallthrough": 2,
"no-floating-decimal": 2,
"no-implicit-coercion": [2, {"boolean": false}],
"no-implied-eval": 2,
"no-invalid-this": 2,
"no-iterator": 2,
"no-labels": 2,
"no-lone-blocks": 2,
"no-loop-func": 2,
"no-magic-numbers": [1, {
"ignoreArrayIndexes": true,
"ignore": [-1, 0, 1, 2, 100]
}],
"no-multi-spaces": 2,
"no-multi-str": 2,
"no-native-reassign": 2,
"no-new-func": 2,
"no-new-wrappers": 2,
"no-new": 2,
"no-octal-escape": 2,
"no-octal": 2,
"no-param-reassign": 0,
"no-process-env": 2,
"no-proto": 2,
"no-redeclare": 2,
"no-return-assign": [2, "always"],
"no-script-url": 2,
"no-self-compare": 2,
"no-sequences": 2,
"no-throw-literal": 2,
"no-unused-expressions": 2,
"no-useless-call": 2,
"no-useless-concat": 2,
"no-void": 2,
"no-warning-comments": 1,
"no-with": 2,
"radix": 2,
"vars-on-top": 2,
"wrap-iife": [2, "inside"],
"yoda": 2,

// Strict Mode
"strict": [2, "global"],

// Variables
"init-declarations": 0,
"no-catch-shadow": 2,
"no-delete-var": 2,
"no-label-var": 2,
"no-shadow-restricted-names": 2,
"no-shadow": 2,
"no-undef-init": 2,
"no-undef": 2,
"no-undefined": 2,
"no-unused-vars": 2,
"no-use-before-define": [2, "nofunc"],

// Node.js and CommonJS
"callback-return": 2,
"global-require": 2,
"handle-callback-err": 2,
"no-mixed-requires": [2, true],
"no-new-require": 2,
"no-path-concat": 2,
"no-process-exit": 2,
"no-restricted-modules": 0,
"no-sync": 0,

//Stylistic Issues
"array-bracket-spacing": [2, "never"],
"block-spacing": [2, "never"],
"brace-style": [2, "1tbs", {"allowSingleLine": false}],
"camelcase": 2,
"comma-spacing": [2, {"before": false, "after": true}],
"comma-style": [2, "last"],
"computed-property-spacing": [2, "never"],
"consistent-this": [2, "self"],
"eol-last": 2,
"func-names": 0,
"func-style": 0,
"id-length": 0,
"id-match": 0,
"indent": [2, 4, {"SwitchCase": 1}],
"jsx-quotes": [2, "prefer-double"],
"key-spacing": [2, {"beforeColon": false, "afterColon": true}],
"keyword-spacing": 2,
"linebreak-style": [2, "unix"],
"lines-around-comment": 0,
"max-depth": [2, 3],
"max-len": [2, 120, 4],
"max-nested-callbacks": [2, 3],
"max-params": [2, 5],
"max-statements": 0,
"new-cap": 2,
"new-parens": 2,
"newline-after-var": 0,
"no-array-constructor": 0,
"no-bitwise": 0,
"no-continue": 0,
"no-inline-comments": 0,
"no-lonely-if": 2,
"no-mixed-spaces-and-tabs": [2, "smart-tabs"],
"no-multiple-empty-lines": [2, {"max": 2}],
"no-nested-ternary": 2,
"no-new-object": 2,
"no-plusplus": 2,
"no-restricted-syntax": [2, "WithStatement"],
"no-spaced-func": 2,
"no-ternary": 0,
"no-trailing-spaces": 2,
"no-underscore-dangle": 0,
"no-unneeded-ternary": 2,
"object-curly-spacing": [2, "never"],
"one-var": 0,
"operator-assignment": 0,
"operator-linebreak": 0,
"padded-blocks": [2, "never"],
"quote-props": 0,
"quotes": [2, "single"],
"require-jsdoc": 0,
"semi-spacing": [2, {"before": false, "after": true}],
"semi": 2,
"sort-vars": 0,
"space-before-blocks": 2,
"space-before-function-paren": [2, "never"],
"space-in-parens": [2, "never"],
"space-infix-ops": 2,
"space-unary-ops": [2, {"words": true, "nonwords": false}],
"spaced-comment": 0,
"wrap-regex": 0
}
"extends": "tui"
}
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Unsure where to begin contributing to TOAST UI? You can start by looking through
### Development WorkFlow
- Set up your development environment
- Make change from a right branch
- Be sure the code passes `npm run lint`, `npm run test`
- Be sure the code passes `npm run eslint`, `npm run test`
- Make a pull request

### Development environment
Expand Down
Loading

0 comments on commit b8999b7

Please sign in to comment.