Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing schedule.category from 'time' to 'allday' doesn't move to all day row, even after updateSchedule() #434

Closed
mariusa opened this issue Oct 14, 2019 · 4 comments · Fixed by #451 or SimHub/simhub-electron-calendar#3
Closed

changing schedule.category from 'time' to 'allday' doesn't move to all day row, even after updateSchedule() #434

mariusa opened this issue Oct 14, 2019 · 4 comments · Fixed by #451 or SimHub/simhub-electron-calendar#3
Labels
Bug Category: Schedule P❕ Low Prioirty

Comments

@mariusa
Copy link

mariusa commented Oct 14, 2019 •
edited
Loading

Hi,

When changing schedule.category from 'time' to 'allday' and invoking updateSchedule, the schedule is NOT moved to all day row (other updates work). If reloading the page, then schedule shows properly.
@mariusa mariusa changed the title Request: please allow dragging schedule between regular hours & "All day" changing schedule.category from 'time' to 'allday' doesn't move to all day row, even after updateSchedule() Oct 20, 2019
@jungeun-cho
Copy link
Contributor

When updating the schedule, if the category value is 'allday', you should also set the isAllDay property to true internally.

If you can't wait for a patch, use isAllDay.

jungeun-cho added a commit that referenced this issue Oct 29, 2019
@jungeun-cho
resolve: issues(fix #434, fix #421, fix #437)
07da5c1
@jungeun-cho jungeun-cho mentioned this issue Oct 29, 2019
Merged
7 tasks
@mariusa
Copy link
Author

mariusa commented Oct 30, 2019

@jungeun-cho After merging the pull request, would you please also make a new release to include this and latest fixes?

@jungeun-cho
Copy link
Contributor

@mariusa
I think a patch version will be released next week.

jungeun-cho added a commit that referenced this issue Nov 5, 2019
@jungeun-cho
Merge pull request #451 from nhn/fix/issues-update-schedule
32f172b 
resolve: issues (fix #434, fix #421, fix #437)
@mariusa
Copy link
Author

mariusa commented Nov 5, 2019

@jungeun-cho I just wanted to say Thank you. The new release works great!

@snyk-bot snyk-bot mentioned this issue Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Category: Schedule P❕ Low Prioirty
Projects
None yet
Milestone
No milestone
2 participants
@mariusa @jungeun-cho