Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timezone: wrong offset calculation when offsets are 30 minutes apart (first tz is 30 minutes ahead than second) #488

Closed
snyaggarwal opened this issue Jan 16, 2020 · 2 comments · Fixed by #491 or SimHub/simhub-electron-calendar#3
Closed

Timezone: wrong offset calculation when offsets are 30 minutes apart (first tz is 30 minutes ahead than second) #488

snyaggarwal opened this issue Jan 16, 2020 · 2 comments · Fixed by #491 or SimHub/simhub-electron-calendar#3
Labels
Bug Category: Timezone

Comments

@snyaggarwal
Copy link

Timezones comparison rendering works well except this one case when the first timezone is 30 minutes ahead of the second. Rather than subtracting 30 minutes from the second timezone its adding 30 minutes to it.
Please take a look at this codepen.
The timezones are rendered wrong (relatively).

Expected behavior - first timezone(+570) should be 30 minutes ahead of the second timezone(+540).
@jungeun-cho
Copy link
Contributor

As you said, the time slot in the second time zone is incorrectly displayed.

If you see the screenshot below, this is correct.

스크린샷 2020-01-21 23 46 11

I'll test it and patch it.

@jungeun-cho jungeun-cho mentioned this issue Jan 22, 2020
Merged
7 tasks
jungeun-cho added a commit that referenced this issue Jan 23, 2020
@jungeun-cho
fix : Resolved an issue where the time range was not normally represe…
a6f489d 
…nted in the time grid when the difference between the main time zone offset and the secondary time zone offset was less than 1 hour (fix #488)
jungeun-cho added a commit that referenced this issue Jan 23, 2020
@jungeun-cho
Merge pull request #491 from nhn/fix/issue-470-487-488
eaf338b 
Fix: bug fixes (fix #470, fix #487, fix #488)
@snyaggarwal
Copy link
Author

Thanks

@snyk-bot snyk-bot mentioned this issue Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Category: Timezone
Projects
None yet
Milestone
No milestone
2 participants
@snyaggarwal @jungeun-cho