chore: fix any type #255

jungeun-cho · 2018-12-29T06:56:10Z

Please check if the PR fulfills these requirements

It's submitted to right branch according to our branching model
It's right issue type on title
When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
The commit message follows our guidelines
Tests for the changes have been added (for bug fixes/features)
Docs have been added/updated (for bug fixes/features)
It does not introduce a breaking change or has description for the breaking change

Description

chore: fix any type
apply tslint

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

dongsik-yoo · 2018-12-31T04:36:23Z

으워~~ 엄청 고생 많이 했네요. 수고하셨어요. 리뷰는 수요일에 볼게요.

dongsik-yoo

[01/04] 수고하셨습니다. 리뷰 완료했어요.
함수 파라미터 중에 불필요하게 optional인 부분들은 전반적으로 체크 부탁 드립니다.

dongsik-yoo · 2019-01-04T08:14:43Z

index.d.ts

@@ -1,22 +1,40 @@
 // Type definitions for TOAST UI Calendar v1.9.0
 // TypeScript Version: 3.2.1

-type templateFunc = (...args: Array<any>) => string;
+type DateType = string | TZDate | Date;
+type EventHandlerFunc = (event: any) => void;


이벤트 핸들러의 파라미터도 타입을 지정해야 하는거 아닌지 확인 부탁 드립니다. 다른 쪽은 어떻게 했어요?

네, 수정하겠습니다.

dongsik-yoo · 2019-01-04T08:16:21Z

index.d.ts

+    color: string;
+    day: number;
+    label: string;
+    left: number;


color, left, width는 인터페이스로 내보내지 않아도 될것 같습니다.

넵, 확인했습니다.

dongsik-yoo · 2019-01-04T08:16:43Z

index.d.ts

+    isToday: boolean;
+    left: number;
+    renderDate: string;
+    width: number;


color, left, width는 인터페이스로 내보내지 않아도 될 것 같습니다.

넵 확인했습니다.

dongsik-yoo · 2019-01-04T08:17:00Z

index.d.ts

+    hiddenSchedules: number;
+    isOtherMonth: boolean;
+    isToday: boolean;
+    left: number;


backgroundColor, color, left, width는 인터페이스로 내보내지 않아도 될 것 같습니다.

넵, 확인했습니다~~!

dongsik-yoo · 2019-01-04T08:19:07Z

index.d.ts

-    timegridDisplayPrimayTime?: templateFunc
-    timegridDisplayTime?: templateFunc
+interface ITimeGridHourLabel {
+    color: string;


color, fontWeight는 인터페이스로 내보내지 않아도 될 것 같습니다.

네, 확인했습니다.

dongsik-yoo · 2019-01-04T08:22:13Z

index.d.ts

+    comingDuration?: (schedule?: ISchedule) => string;
+    monthMoreTitleDate?: (date?: string, dayname?: string) => string;
+    monthMoreClose?: () => string;
+    monthGridHeader?: (model?: IGridDateModel) => string;


파라미터가 optional이 아니니까 물음표 빼야 되지 않을까요?

네, 수정하겠습니다.

dongsik-yoo · 2019-01-04T08:22:35Z

index.d.ts

+    width: number;
+}
+
+interface ITemplateConfig {


옵셔널 파라라미터 한번 확인해 주세요

helper.js를 참고하여 수정하겠습니다.

dongsik-yoo · 2019-01-04T08:23:44Z

index.d.ts

    startDayOfWeek?: number;
-    daynames?: Array<string>;
+    daynames?: string[];


이건 무슨 차이인가요? 컨벤션인가요?

네~ tslint에서 Array<string> => string[]로 심플하게 표현하라고 하더라구요~!

dongsik-yoo · 2019-01-04T08:24:37Z

index.d.ts

        }
    };
-    scheduleFilter?: (...args:Array<any>) => any;
+    scheduleFilter?: (schedule: ISchedule | null) => boolean;


파라미터가 null이 올 수 없을 것 같아요

null타입 삭제하겠습니다.

dongsik-yoo · 2019-01-04T08:25:49Z

index.d.ts

@@ -237,17 +300,17 @@ interface Schedule {
    dragBgColor?: string;
    borderColor?: string;
    customStyle?: string;
-    raw?: any;
+    raw?: IRaw | null;


raw는 any로 가도 됩니다. 그야 말로 any용도입니다. IRaw도 빼도 될것 같아요.

넵, 알겠습니다.

jungeun-cho

@dongsik-yoo 피드백 내용 적용하였습니다.
추가적으로 type 선언이이 글로벌하게 사용되더라구요.
모듈(네임스페이스)안으로 이동하여 독립적이로 선언된 타입을 사용하도록 수정하였습니다.

jungeun-cho · 2019-01-10T01:07:32Z

index.d.ts

-    timegridDisplayPrimayTime?: templateFunc
-    timegridDisplayTime?: templateFunc
+interface ITimeGridHourLabel {
+    color: string;


네, 확인했습니다.

jungeun-cho · 2019-01-10T01:08:12Z

index.d.ts

+    hiddenSchedules: number;
+    isOtherMonth: boolean;
+    isToday: boolean;
+    left: number;


넵, 확인했습니다~~!

jungeun-cho · 2019-01-10T01:13:18Z

index.d.ts

+    isToday: boolean;
+    left: number;
+    renderDate: string;
+    width: number;


넵 확인했습니다.

jungeun-cho · 2019-01-10T01:13:46Z

index.d.ts

+    color: string;
+    day: number;
+    label: string;
+    left: number;


넵, 확인했습니다.

jungeun-cho · 2019-01-10T01:14:34Z

index.d.ts

    startDayOfWeek?: number;
-    daynames?: Array<string>;
+    daynames?: string[];


네~ tslint에서 Array<string> => string[]로 심플하게 표현하라고 하더라구요~!

jungeun-cho · 2019-01-10T01:15:17Z

index.d.ts

        }
    };
-    scheduleFilter?: (...args:Array<any>) => any;
+    scheduleFilter?: (schedule: ISchedule | null) => boolean;


null타입 삭제하겠습니다.

jungeun-cho · 2019-01-10T01:15:43Z

index.d.ts

@@ -237,17 +300,17 @@ interface Schedule {
    dragBgColor?: string;
    borderColor?: string;
    customStyle?: string;
-    raw?: any;
+    raw?: IRaw | null;


넵, 알겠습니다.

jungeun-cho · 2019-01-10T01:53:32Z

index.d.ts

@@ -1,22 +1,40 @@
 // Type definitions for TOAST UI Calendar v1.9.0
 // TypeScript Version: 3.2.1

-type templateFunc = (...args: Array<any>) => string;
+type DateType = string | TZDate | Date;
+type EventHandlerFunc = (event: any) => void;


네, 수정하겠습니다.

jungeun-cho · 2019-01-10T01:55:19Z

index.d.ts

+    width: number;
+}
+
+interface ITemplateConfig {


helper.js를 참고하여 수정하겠습니다.

jungeun-cho · 2019-01-10T02:02:05Z

index.d.ts

+    comingDuration?: (schedule?: ISchedule) => string;
+    monthMoreTitleDate?: (date?: string, dayname?: string) => string;
+    monthMoreClose?: () => string;
+    monthGridHeader?: (model?: IGridDateModel) => string;


네, 수정하겠습니다.

dongsik-yoo · 2019-01-10T06:20:32Z

@jungeun-cho 수고 많으셨습니다.

chore: fix any type

adf719a

jungeun-cho requested a review from dongsik-yoo December 29, 2018 06:56

dongsik-yoo suggested changes Jan 4, 2019

View reviewed changes

chore: apply PR feedback

7044452

jungeun-cho commented Jan 10, 2019

View reviewed changes

chore: update namespace

e30acdc

jungeun-cho merged commit 0fe07f3 into master Jan 11, 2019

jungeun-cho deleted the chore/fix-any-type branch July 5, 2019 08:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: fix any type #255

chore: fix any type #255

jungeun-cho commented Dec 29, 2018

dongsik-yoo commented Dec 31, 2018

dongsik-yoo left a comment

dongsik-yoo Jan 4, 2019

jungeun-cho Jan 10, 2019

dongsik-yoo Jan 4, 2019

jungeun-cho Jan 10, 2019

dongsik-yoo Jan 4, 2019

jungeun-cho Jan 10, 2019

dongsik-yoo Jan 4, 2019

jungeun-cho Jan 10, 2019

dongsik-yoo Jan 4, 2019

jungeun-cho Jan 10, 2019

dongsik-yoo Jan 4, 2019

jungeun-cho Jan 10, 2019

dongsik-yoo Jan 4, 2019

jungeun-cho Jan 10, 2019

dongsik-yoo Jan 4, 2019

jungeun-cho Jan 10, 2019

dongsik-yoo Jan 4, 2019

jungeun-cho Jan 10, 2019

dongsik-yoo Jan 4, 2019

jungeun-cho Jan 10, 2019

jungeun-cho left a comment •

edited

Loading

jungeun-cho Jan 10, 2019

jungeun-cho Jan 10, 2019

jungeun-cho Jan 10, 2019

jungeun-cho Jan 10, 2019

jungeun-cho Jan 10, 2019

jungeun-cho Jan 10, 2019

jungeun-cho Jan 10, 2019

jungeun-cho Jan 10, 2019

jungeun-cho Jan 10, 2019

jungeun-cho Jan 10, 2019

dongsik-yoo commented Jan 10, 2019

chore: fix any type #255

chore: fix any type #255

Conversation

jungeun-cho commented Dec 29, 2018

Please check if the PR fulfills these requirements

Description

dongsik-yoo commented Dec 31, 2018

dongsik-yoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jungeun-cho left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dongsik-yoo commented Jan 10, 2019

jungeun-cho left a comment •

edited

Loading