Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:move YAxis when set rotateLabel false #245

Merged
merged 3 commits into from
Jan 17, 2020
Merged

fix:move YAxis when set rotateLabel false #245

merged 3 commits into from
Jan 17, 2020

Conversation

jung-han
Copy link
Member

@jung-han jung-han commented Jan 9, 2020

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • move YAxis when set rotateLabel false

image

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@jung-han jung-han changed the title fix:rotate label false bug fix:move YAxis when set rotateLabel false Jan 9, 2020
@jung-han
Copy link
Member Author

jung-han commented Jan 9, 2020

Can one of the admins verify this patch?

junghwan-park
junghwan-park approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@junghwan-park junghwan-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

렌더러가 SVG로 바뀌고나서 html string에서 plain text로 변경 안된 부분들이 있었나보네요. 완료입니다!

@jinwoo-kim-nhn
Copy link
Contributor

리뷰완료했습니다. 수고하셨어요~~

@jung-han jung-han merged commit 65fd507 into master Jan 17, 2020
@jung-han jung-han deleted the fix/rotateLabel-false-bug branch January 17, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junghwan-park junghwan-park junghwan-park approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jung-han @jinwoo-kim-nhn @junghwan-park