Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improving tooltip #255

Merged
merged 6 commits into from
Feb 3, 2020
Merged

fix: improving tooltip #255

merged 6 commits into from
Feb 3, 2020

Conversation

jung-han
Copy link
Member

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

related issue: #252

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

junghwan-park
junghwan-park approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@junghwan-park junghwan-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

완료입니다!

@jinwoo-kim-nhn
Copy link
Contributor

수고하셨습니다.

@jung-han jung-han merged commit 389f5f0 into master Feb 3, 2020
@jung-han jung-han deleted the fix/detect-event-on-tooltip branch February 3, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junghwan-park junghwan-park junghwan-park approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jung-han @jinwoo-kim-nhn @junghwan-park