Fix: Don't call methods that aren't available in the node environment #27
Conversation
jkeen
changed the title
|
Can one of the admins verify this patch? |
src/js/browser.js
Outdated
| var appName = nav.appName.replace(/\s/g, '_'); | ||
| var userAgent = nav.userAgent; | ||
| if (window && window.navigator) { | ||
| var nav = window.navigator; |
There was a problem hiding this comment.
Can you please run eslint? Because we're using indent 4 at tui-code-snippet.
src/js/browser.js
Outdated
| } | ||
| } | ||
| else { | ||
| browser.node = true |
There was a problem hiding this comment.
I think this is not enough to detect a node. There is process object to detect it. What do you think?
There was a problem hiding this comment.
That’s fair, we don’t have to assume it’s node and it might be out of scope for what this utility is supposed to do. I can skip that and only check if window and navigator exists, and make no assumptions if it doesn’t.
|
@jung-han Please verify this PR. I leave some comments. |
|
@jung-han I think this is ready. Once this gets merged and |
|
@jkeen Sorry for late😢. Thanks for PR! |
I'm using tui-calendar in an ember app, and when loading it on the server it errors out when calling
window.navigator.appName, sincewindow.navigatoris null in the node environment.This change checks for window and window.navigator, and if those don't exist, it assumes it's the node environment and marks the
browserobject as such.