docs: edit the way to set usageStatistics (#17)

* docs: edit the way to set usageStatistics * chore: add test browsers * chore: follow eslint tui/es6 * chore: update karma-webdriver-launcher to v1.2.0
nhn · Aug 22, 2019 · 9479bea · 9479bea
1 parent 7ce6cdc
commit 9479bea
Show file tree

Hide file tree

Showing 6 changed files with 804 additions and 543 deletions.
diff --git a/README.md b/README.md
@@ -38,13 +38,12 @@ It also serves as important index to determine the future course of projects.
 To disable GA, use the following `usageStatistics` option when creating the instance.
 
 ```js
-var instance = new ContextMenu(container);
+
 var options = {
     ...
     usageStatistics: false
 }
-
-instance.register(target, options);
+var instance = new ContextMenu(container, options);
 ```
 
 Or, include [`tui-code-snippet`](https://github.com/nhn/tui.code-snippet)(**v1.5.0** or **later**) and then immediately write the options as follows:

diff --git a/docs/README.md b/docs/README.md
@@ -4,7 +4,7 @@
 
 ## Documents
 
-- [Code of Conducting](../CODE_OF_CONDUCT.md)
+- [Code of Conduct](../CODE_OF_CONDUCT.md)
 - [Contributing Guide](../CONTRIBUTING.md)
 - [Commit Message Convention](COMMIT_MESSAGE_CONVENTION.md)
 - [API & Examples](https://nhn.github.io/tui.context-menu/latest/)
diff --git a/karma.conf.js b/karma.conf.js
@@ -2,11 +2,11 @@
  * Config file for testing
  * @author NHN. FE Development Lab <dl_javascript@nhn.com>
  */
-var pkg = require('./package.json');
-var ExtractTextPlugin = require('extract-text-webpack-plugin');
-var SafeUmdPlugin = require('safe-umd-webpack-plugin');
+const pkg = require('./package.json');
+const ExtractTextPlugin = require('extract-text-webpack-plugin');
+const SafeUmdPlugin = require('safe-umd-webpack-plugin');
 
-var webdriverConfig = {
+const webdriverConfig = {
     hostname: 'fe.nhnent.com',
     port: 4444,
     remoteHost: true
@@ -69,8 +69,8 @@ function setConfig(defaultConfig, server) {
             'IE8',
             'IE9',
             'IE10',
-            // 'IE11',
-            // 'Edge',
+            'IE11',
+            'Edge',
             'Chrome-WebDriver',
             'Firefox-WebDriver'
             // 'Safari-WebDriver' // active only when safari test is needed
@@ -82,14 +82,14 @@ function setConfig(defaultConfig, server) {
             reporters: [
                 {
                     type: 'html',
-                    subdir: function(browser) {
-                        return 'report-html/' + browser;
+                    subdir(browser) {
+                        return `report-html/${browser}`;
                     }
                 },
                 {
                     type: 'cobertura',
-                    subdir: function(browser) {
-                        return 'report-cobertura/' + browser;
+                    subdir(browser) {
+                        return `report-cobertura/${browser}`;
                     },
                     file: 'cobertura.txt'
                 }
@@ -107,7 +107,7 @@ function setConfig(defaultConfig, server) {
 }
 
 module.exports = function(config) {
-    var defaultConfig = {
+    const defaultConfig = {
         basePath: './',
         frameworks: [
             'fixture',
@@ -158,7 +158,7 @@ module.exports = function(config) {
             },
             plugins: [
                 new SafeUmdPlugin(),
-                new ExtractTextPlugin(pkg.name + '.css')
+                new ExtractTextPlugin(`${pkg.name}.css`)
             ]
         },
         port: 9876,