fixed some scrollFollow code

nhn · Jan 2, 2020 · 8351c73 · 8351c73
1 parent f6c1a2c
commit 8351c73
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 2 deletions.
diff --git a/apps/core/src/js/extensions/scrollFollow.sectionManager.js b/apps/core/src/js/extensions/scrollFollow.sectionManager.js
@@ -5,7 +5,8 @@
 
 'use strict';
 
-var setextHeaderRx = /^ *(?:\={1,}|-{1,})\s*$/;
+var FIND_SETEXT_HEADER_RX = /^ *(?:\={1,}|-{1,})\s*$/,
+    FIND_SPACE = /\s/g;
 
 /*
  * SectionManager
@@ -104,7 +105,10 @@ SectionManager.prototype._eachLineState = function(iteratee) {
         ) {
             isSection = true;
         //setext header
-        } else if (this.cm.getLine(i+1) && this.cm.getLine(i+1).match(setextHeaderRx)) {
+        } else if (this.cm.getLine(i).replace(FIND_SPACE, '') !== ''
+            && this.cm.getLine(i+1)
+            && this.cm.getLine(i+1).match(FIND_SETEXT_HEADER_RX)
+        ) {
             isSection = true;
         }
 

diff --git a/apps/core/test/extensions/scrollFollow.sectionManager.spec.js b/apps/core/test/extensions/scrollFollow.sectionManager.spec.js
@@ -161,6 +161,41 @@ describe('scrollFollow.sectionManager', function() {
             expect(sectionManager.getSectionList().length).toEqual(3);
         });
 
+        it('dont make section with line', function() {
+            ned.setValue([
+                'paragraph',
+                'header1',
+                '=======',
+                'paragraph',
+                ' ',
+                '------',
+                'paragraph'
+            ].join('\n'));
+
+
+            sectionManager.makeSectionList();
+
+            expect(sectionManager.getSectionList().length).toEqual(2);
+        });
+
+        xit('dont make section with line #2', function() {
+            ned.setValue([
+                'paragraph',
+                'header1',
+                '=======',
+                '``` javascript',
+                'var mm = 1;',
+                '```',
+                '------',
+                'paragraph'
+            ].join('\n'));
+
+
+            sectionManager.makeSectionList();
+
+            expect(sectionManager.getSectionList().length).toEqual(2);
+        });
+
         it('section list have line info', function() {
             var sectionList;