Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pasting into the table does not work correctly #365

Closed
sohee-lee7 opened this issue Jan 15, 2019 · 0 comments
Closed

Pasting into the table does not work correctly #365

sohee-lee7 opened this issue Jan 15, 2019 · 0 comments
Milestone
1.3.1

Comments

@sohee-lee7
Copy link
Contributor

Version

v1.3.0

Test Environment

Chrome

Current Behavior

pasteintocell_before

  • If insert one line text into cell of table, the text is pasted into last line of the cell.
  • If insert multi line text into cell of table, the table is split.

Expected Behavior

Pasting into the table does work correctly.
This was referenced Jan 15, 2019
Closed
Merged
@sohee-lee7 sohee-lee7 added this to the 1.3.1 milestone Jan 24, 2019
@sohee-lee7 sohee-lee7 mentioned this issue Feb 20, 2019
Closed
seonim-ryu pushed a commit that referenced this issue Jan 2, 2020
@shiren @seonim-ryu
sectionManager dosn't identify correctly hr and setext header in some…
e2c7f03 
… case fixed #365
seonim-ryu pushed a commit that referenced this issue Jan 2, 2020
@sohee-lee7 @seonim-ryu
feat: paste into cell of table (close #365 #167) (#364)
b34f98a 
* feat: paste clipboard to table when paste event

* fix: clipboard.items doesn't exist in ie

* refactor: make common function

* fix: isIntable can't check whether range is in table

* refactor: imporve to check that node is possible in ww table

* feat: make clipboard for ie11

* fix: undo is not work when pasting into table

* refactor: modify to insert 'br' when unwrap amd imporve test code and comment

* fix: remove unuse test case

* fix: exception when get Text from i18n

* fix: move saveUndoState because squire change range when saveUndoState

* fix: resolve exception when select block at start or end of line

* refactor: move all process clipboard to WwTablePasteHelper

* fix: cursor is wrong after paste in IE

* fix: cursor is wrong when startOffset is less than endOffset

When the offset of one line (startOffset) is less than the offset on the
entire line (endOffset), cursor is wrong, so couldn't delete contents of
range.

* fix: exception when fragement don't have child

* fix: reflect code review

* fix: remove unuse code

* doc: update commont

* fix: cursor is wrong when endOffset is same the length of text in line

* fix: reflect code review
seonim-ryu pushed a commit that referenced this issue Jan 6, 2020
@sohee-lee7 @seonim-ryu
feat: paste into cell of table (close #365 #167) (#364)
54a709c 
* feat: paste clipboard to table when paste event

* fix: clipboard.items doesn't exist in ie

* refactor: make common function

* fix: isIntable can't check whether range is in table

* refactor: imporve to check that node is possible in ww table

* feat: make clipboard for ie11

* fix: undo is not work when pasting into table

* refactor: modify to insert 'br' when unwrap amd imporve test code and comment

* fix: remove unuse test case

* fix: exception when get Text from i18n

* fix: move saveUndoState because squire change range when saveUndoState

* fix: resolve exception when select block at start or end of line

* refactor: move all process clipboard to WwTablePasteHelper

* fix: cursor is wrong after paste in IE

* fix: cursor is wrong when startOffset is less than endOffset

When the offset of one line (startOffset) is less than the offset on the
entire line (endOffset), cursor is wrong, so couldn't delete contents of
range.

* fix: exception when fragement don't have child

* fix: reflect code review

* fix: remove unuse code

* doc: update commont

* fix: cursor is wrong when endOffset is same the length of text in line

* fix: reflect code review
js87zz pushed a commit that referenced this issue Jun 17, 2021
@shiren @seonim-ryu
sectionManager dosn't identify correctly hr and setext header in some…
1f8749a 
… case fixed #365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.1
Development

No branches or pull requests
1 participant
@sohee-lee7