Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support markdownIt#render env parameter in convertor.js #375

Closed
suchun0 opened this issue Jan 23, 2019 · 0 comments · Fixed by #467
Closed

Support markdownIt#render env parameter in convertor.js #375

suchun0 opened this issue Jan 23, 2019 · 0 comments · Fixed by #467
Labels
Category: Convertor Feature New features to implement P 1
Milestone
1.4.0

Comments

@suchun0
Copy link

suchun0 commented Jan 23, 2019 •
edited
Loading

In my case, env parameter is needed when I use the footnotes plugin.
https://github.com/markdown-it/markdown-it-footnote/blob/master/index.js#L12

Can TUI-Editor support second env parameter for the markdownIt#render method in convertor.js?
https://github.com/nhnent/tui.editor/blob/master/src/js/convertor.js#L94
@sohee-lee7 sohee-lee7 added Category: Convertor Feature New features to implement and removed Type: Feature Request labels Feb 21, 2019
@sohee-lee7 sohee-lee7 added this to the 1.4.0 milestone Feb 28, 2019
@sohee-lee7 sohee-lee7 added the P 1 label Feb 28, 2019
@sohee-lee7 sohee-lee7 modified the milestones: 1.5.0, 1.4.0 Apr 3, 2019
sohee-lee7 pushed a commit that referenced this issue Apr 9, 2019
feat: add env param for render of markdownit (close: #375)
ae91cd4
@sohee-lee7 sohee-lee7 mentioned this issue Apr 9, 2019
Merged
6 tasks
sohee-lee7 added a commit that referenced this issue Apr 10, 2019
@sohee-lee7
feat: add env param for render of markdownit (close: #375) (#467)
4111722
seonim-ryu pushed a commit that referenced this issue Jan 2, 2020
@shiren @seonim-ryu
when added table in markdown last cell didn't appear in preview fixed #…
98b386f 
…375
seonim-ryu pushed a commit that referenced this issue Jan 2, 2020
@sohee-lee7 @seonim-ryu
feat: add env param for render of markdownit (close: #375) (#467)
3171350
seonim-ryu pushed a commit that referenced this issue Jan 6, 2020
@sohee-lee7 @seonim-ryu
feat: add env param for render of markdownit (close: #375) (#467)
bfed434
js87zz pushed a commit that referenced this issue Jun 17, 2021
@shiren @seonim-ryu
when added table in markdown last cell didn't appear in preview fixed #…
9625e2c 
…375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Convertor Feature New features to implement P 1
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

feat: add env param for render of markdownit (close: #375) nhn/tui.editor
2 participants
@suchun0 @sohee-lee7