<feat> add some aria attributes #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are still many missing, in particular a lot of labels for accessible names.
js87zz
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
@lucaslcode
Thanks for contributing.
It's a good PR. I need to improve a11y for keyboard operation later :)
|
@lucaslcode |
js87zz
pushed a commit
that referenced
this pull request
Aug 4, 2021
There are still many missing, in particular a lot of labels for accessible names.
|
I get errors that |
|
@lucaslcode |
ahamelers
pushed a commit
to ahamelers/tui.editor
that referenced
this pull request
Aug 21, 2023
There are still many missing, in particular a lot of labels for accessible names.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still many missing, in particular a lot of labels for accessible names.
I wasn't able to get the build system working, despite following the instructions. Perhaps it hasn't been updated for v3?