fix: table head is missing when pasting the table from ms word #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lja1018
approved these changes
Oct 6, 2021
Comment on lines
160
to
164
| if (startFromBody) { | ||
| return schema.nodes.table.create(null, [createTableBody(rows, columnCount, schema)]); | ||
| if (isInTable) { | ||
| return schema.nodes.table.create(null, [createTableBody(rows, columnCount, schema)]); | ||
| } | ||
| } |
There was a problem hiding this comment.
if (startFromBody && isInTable)은 어떤가요?
There was a problem hiding this comment.
아 막판에 코드 변경하면서 이렇게 되었군요. 넵 변경하겠습니다~!
Comment on lines
105
to
107
| const dummyCell = tableHeadCell.createAndFill()!; | ||
|
|
||
| cells.push(dummyCell); |
There was a problem hiding this comment.
Suggested change
| const dummyCell = tableHeadCell.createAndFill()!; | |
| cells.push(dummyCell); | |
| cells.push(tableHeadCell.createAndFill()); |
바로 사용해도 되지 않나요?
There was a problem hiding this comment.
그렇긴한데..요건 가독성 때문에 변수를 선언한 다음에 사용하였습니다~!
dongsik-yoo
approved these changes
Oct 6, 2021
| @@ -97,6 +97,19 @@ function creatTableBodyDummyRow(columnCount: number, schema: Schema) { | |||
| return tableRow.create({ dummyRowForPasting: true }, cells); | |||
| } | |||
|
|
|||
| function creatTableHeadDummyRow(columnCount: number, schema: Schema) { | |||
There was a problem hiding this comment.
이 함수 쓰는데가 PR에서는 안 보이는데요. 사용처가 있는거죠?
|
|
||
| if (items) { | ||
| if (items?.length === 1) { |
There was a problem hiding this comment.
넵 워드에서 복사한 클립보드 데이터 종류가 여러 가지 타입으로 존재하는데 그 중에 이미지 데이터도 있어서 조건을 추가하였습니다! 해당 조건을 추가하지 않으면 테이블이 무조건 이미지 형태로만 복사가 되어서 문제가 됩니다.
js87zz
force-pushed
the
fix/paste-table-ms-word
branch
from
ff7f1e8
to
d6259d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
as-is
to-be
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨