fix: console error when creating a list with inline style (close #221) #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/js/wysiwygCommands/ul.js
Outdated
| range.setStart(newLIs[0].firstChild, startOffset); | ||
| range.setEnd(newLIs[newLIs.length - 1].firstChild, endOffset); | ||
| range.setStart(newStartContainer, startOffset); | ||
| range.setEnd(newEndContainer, endOffset); |
There was a problem hiding this comment.
위에 ol.js, task.js와 비슷한 패턴이 반복해서 쓰이는것 같음으로 재사용할 여지가 많으면, 중복된 패턴을 모아서 함수로 만들어도 좋을것 같습니다.
|
수고하셨습니다. 리뷰 완료했습니다. |
|
[6/26] 저도 이견 없습니다. 고생하셨어요~ |
shiren
reviewed
Jul 3, 2018
| */ | ||
| const containsNode = function(root, node) { | ||
| const walker = document.createTreeWalker(root, 4, null, false); | ||
| let found = root === node; |
| let found = root === node; | ||
|
|
||
| while (!found && walker.nextNode()) { | ||
| found = walker.currentNode === node; |
| * @returns {Range} - range instance | ||
| * @memberof WysiwygEditor | ||
| */ | ||
| setSelectionByContainerAndOffset(startContainer, startOffset, endContainer, endOffset) { |
seonim-ryu
pushed a commit
that referenced
this pull request
Jan 2, 2020
seonim-ryu
pushed a commit
that referenced
this pull request
Jan 2, 2020
seonim-ryu
pushed a commit
that referenced
this pull request
Jan 6, 2020
js87zz
pushed a commit
that referenced
this pull request
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
#221
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨