fix: update getOffset (fix #849) #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update end condition to work when Editor is in Modal or Portal
dbuchet
changed the title
seonim-ryu
reviewed
Mar 24, 2020
Changing statement according to @seonim-ryu
seonim-ryu
approved these changes
Mar 26, 2020
There was a problem hiding this comment.
@dbuchet I reviewed it. Thank you for contributing and I will merge this PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Update loop-end condition to work when Editor is in Modal or Portal
Description
Related issue: #849
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨