Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong editing layer position with translate style(#979) #1010

Merged
merged 9 commits into from
May 7, 2020

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Apr 21, 2020

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • related issue(When I'm using with Semantic ui #979)
  • additional context
    • position: fixed is based on viewport as container block but when the one of the ancestors has transform, perspective and filter, container block is changed as that ancestor block. So, the position of the layer should be calculated by using fixed grid container block with absolute position.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@@ -17,6 +17,8 @@ export class SelectEditor implements CellEditor {

private selectFinish = false;

private isMounted = false;
Copy link

@dongwoo-kim dongwoo-kim Apr 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 변수는 mounted라 해도 되지 않을까요? 요즘은 함수가 아닌 이상 is를 안붙이는 쪽으로 네이밍하고 있어서..
바로 위에 있는 selectFinishis가 없으니 일관성 차원에서도 좋을 것 같습니다.

라고 적었는데, mounted 메소드가 있어서 문제군요. 답이 없네요 -ㅁ-

Copy link
Member

@jung-han jung-han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이견 없습니다!

Copy link

@dongwoo-kim dongwoo-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료. 고생하셨습니다!

@js87zz js87zz merged commit 84926f9 into master May 7, 2020
@js87zz js87zz deleted the fix/editing-layer-position branch May 22, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants