-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong editing layer position with translate style(#979) #1010
Conversation
@@ -17,6 +17,8 @@ export class SelectEditor implements CellEditor { | |||
|
|||
private selectFinish = false; | |||
|
|||
private isMounted = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 변수는 mounted
라 해도 되지 않을까요? 요즘은 함수가 아닌 이상 is
를 안붙이는 쪽으로 네이밍하고 있어서..
바로 위에 있는 selectFinish
도 is
가 없으니 일관성 차원에서도 좋을 것 같습니다.
라고 적었는데, mounted
메소드가 있어서 문제군요. 답이 없네요 -ㅁ-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이견 없습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 완료. 고생하셨습니다!
Please check if the PR fulfills these requirements
fix #xxx[,#xxx]
, where "xxx" is the issue number)Description
position: fixed
is based on viewport as container block but when the one of the ancestors hastransform
,perspective
andfilter
, container block is changed as that ancestor block. So, the position of the layer should be calculated by using fixed grid container block withabsolute
position.Thank you for your contribution to TOAST UI product. 🎉 😘 ✨