Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parent elements could not be scrolled when cursor above the grid #1940

Merged
merged 1 commit into from
Jul 13, 2023
Merged

fix: parent elements could not be scrolled when cursor above the grid #1940

merged 1 commit into from
Jul 13, 2023

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • Fixed an issue where parent elements could not be scrolled when the cursor was above the grid.
    • This was caused by calling preventDefault regardless of whether the grid was scrollable or not.

As-Is

To-Be

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@jajugoguma jajugoguma self-assigned this Jul 11, 2023
@jajugoguma jajugoguma merged commit a29d911 into master Jul 13, 2023
3 of 4 checks passed
@jajugoguma jajugoguma deleted the fix/can_not_scorll_parent branch July 13, 2023 00:49
@fix-a-lot
Copy link

안그래도 이것 때문에 버전 내렸었는데 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhrinae adhrinae adhrinae approved these changes

@jwlee1108 jwlee1108 jwlee1108 approved these changes

@heenakwag heenakwag Awaiting requested review from heenakwag

@sunyoungBae sunyoungBae Awaiting requested review from sunyoungBae

Assignees

@jajugoguma jajugoguma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jajugoguma @fix-a-lot @adhrinae @jwlee1108