Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unexpected change of fixedHeight (fix #269) #274

Merged
merged 2 commits into from
Feb 22, 2019
Merged

Conversation

dongwoo-kim
Copy link

@dongwoo-kim dongwoo-kim commented Feb 21, 2019

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

fix #269
fix #235


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@dongwoo-kim
Copy link
Author

ok to test

Copy link
Member

@seonim-ryu seonim-ryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[2/22] 리뷰 완료! 이견 없습니다. 👍

@dongwoo-kim dongwoo-kim merged commit 69e8f31 into master Feb 22, 2019
@dongwoo-kim dongwoo-kim deleted the fix/269 branch February 22, 2019 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants