-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First and last name are nil #13
Comments
+1 |
When providing both email and name as scopes. For example "email name" the request URL is being incorrectly transformed with a + between the scope names rather than correctly using a %20. Incorrect: "name+email" Correct: "name%20email" @sebfie helpfully diagnosed the issue and figured out the fix here nhosoya#12 (comment) I wondered if we could get this merged and released in the gem. Closes nhosoya#12 Closes nhosoya#13
This could be because you have already authorized the app. Apple only sends the user object the first time the user authorizes the app. Subsequent authorizations don't send the user object. The user object is what contains the first/last name. Also, the id_token that apple gives out never seems to contain the first/name info, so that means the only time you can get this is the first time you authorize the app. |
I am aware of this and tested multiple times deauthorize good the app. Never got the name. |
We seem to have observed an issue where if you authenticate with TouchID, then everything in the OmniAuth hash is |
When providing both email and name as scopes. For example "email name" the request URL is being incorrectly transformed with a + between the scope names rather than correctly using a %20. Incorrect: "name+email" Correct: "name%20email" @sebfie helpfully diagnosed the issue and figured out the fix here nhosoya#12 (comment) I wondered if we could get this merged and released in the gem. Closes nhosoya#12 Closes nhosoya#13
When providing both email and name as scopes. For example "email name" the request URL is being incorrectly transformed with a + between the scope names rather than correctly using a %20. Incorrect: "name+email" Correct: "name%20email" @sebfie helpfully diagnosed the issue and figured out the fix here nhosoya#12 (comment) I wondered if we could get this merged and released in the gem. Closes nhosoya#12 Closes nhosoya#13
@sdhull , same thread as you, I'll share my findings if I come up with any, I had tried the scope encoding commit that references this issue, but we're still seeing the email coming up as |
When providing both email and name as scopes. For example "email name" the request URL is being incorrectly transformed with a + between the scope names rather than correctly using a %20. Incorrect: "name+email" Correct: "name%20email" @sebfie helpfully diagnosed the issue and figured out the fix here nhosoya#12 (comment) I wondered if we could get this merged and released in the gem. Closes nhosoya#12 Closes nhosoya#13 Co-authored-by: Karl Entwistle <me@karlentwistle.com>
When providing both email and name as scopes. For example "email name" the request URL is being incorrectly transformed with a + between the scope names rather than correctly using a %20. Incorrect: "name+email" Correct: "name%20email" @sebfie helpfully diagnosed the issue and figured out the fix here nhosoya#12 (comment) I wondered if we could get this merged and released in the gem. Closes nhosoya#12 Closes nhosoya#13 fdocr@366272a
I'm receiving the name as user e-mail. Looking in the gem it sets the name with user's email when the name do not came from apple validation. I'm receiving it even in the first access (after removing the app from my account, having to accept and decide if I'll share my email or not). Any solution? Thanks. |
When providing both email and name as scopes. For example "email name" the request URL is being incorrectly transformed with a + between the scope names rather than correctly using a %20. Incorrect: "name+email" Correct: "name%20email" @sebfie helpfully diagnosed the issue and figured out the fix here nhosoya#12 (comment) I wondered if we could get this merged and released in the gem. Closes nhosoya#12 Closes nhosoya#13 fdocr@366272a
hope this merged, or do the same in your app. |
Hello. I'm working on an implementation to use this gem with Devise, and everything is working. The problem I'm facing is that, although I'm requesting the user's name, and it shows up as something I'm requesting on the Apple oauth, the name is nil that gets returned from the gem. Is this a known issue? Any fix for it?
The text was updated successfully, but these errors were encountered: