Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oauth2 version 2.0.0 breaks omniauth-apple #85

Closed
dli1022 opened this issue Aug 15, 2022 · 4 comments
Closed

Oauth2 version 2.0.0 breaks omniauth-apple #85

dli1022 opened this issue Aug 15, 2022 · 4 comments

Comments

@dli1022
Copy link

dli1022 commented Aug 15, 2022

Specifically this line in the Oauth2 2.0.0 release changelog breaks omniauth-apple gem:

"oauth-xx/oauth2#312 - BREAKING: Set :basic_auth as default for :auth_scheme instead of :request_body. This was default behavior before 1.3.0. (@tetsuya, @wy193777)

Apple get token call needs the "client_id" and "client_secret" in the body, which will only be sent if Oauth2 "auth_scheme" type is ":request_body"

Please provide a fix or advice how we can set the :auth_scheme to :request_body through omniquth options.
Thanks

@thenathanjones
Copy link

@nhosoya how can we help get some progress on updating to support OAuth 2.0.0? Many of us using this are also using Facebook and Google strategies which work with the new version and it feels risky to not be able to update.

@smenor
Copy link

smenor commented Sep 26, 2022

Just tagging on a « me-too » to this @nhosoya

nov added a commit to nov/omniauth-apple that referenced this issue Sep 27, 2022
nov added a commit to nov/omniauth-apple that referenced this issue Sep 27, 2022
@nov nov closed this as completed Sep 27, 2022
@smenor
Copy link

smenor commented Sep 27, 2022

Thank you !

@thenathanjones
Copy link

thenathanjones commented Sep 27, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants