Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

included an optional ticket in changePassword function to allow for c… #679

Merged
merged 4 commits into from
Jul 19, 2022

Conversation

Svarto
Copy link
Contributor

@Svarto Svarto commented Jun 6, 2022

This is the nhost-js SDK changes to enable changing password for users that are not logged in but have a valid password reset ticket. See backend hasura-auth PR here: hasura-auth #186

I believe this should work, I struggled a little as I haven't used the machines that you use to create the request that goes into the backend (looks very impressive, nice work by the way). Have a look and let me know if this would work !

…hangeing password of logged out users, matches hasura-auth nhost#186
@Svarto Svarto requested a review from plmercereau as a code owner June 6, 2022 19:34
@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2022

🦋 Changeset detected

Latest commit: 53e20e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@nhost/hasura-auth-js Minor
@nhost/nhost-js Patch
@nhost/react-auth Patch
@nhost/vue Patch
@nhost/apollo Patch
@nhost/nextjs Patch
@nhost/react Patch
@nhost/react-apollo Patch
@nhost-examples/nextjs Patch
@nhost-examples/react-apollo-crm Patch
@nhost-examples/react-apollo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 6, 2022

@Svarto is attempting to deploy a commit to the Nhost Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jun 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Jul 19, 2022 at 7:45AM (UTC)
example-react-apollo ❌ Failed (Inspect) Jul 19, 2022 at 7:45AM (UTC)
example-vue-apollo ❌ Failed (Inspect) Jul 19, 2022 at 7:45AM (UTC)

@szilarddoro
Copy link
Contributor

szilarddoro commented Jun 10, 2022

Hey @Svarto, sorry for not responding to this PR earlier.

Your work on this feature is highly appreciated. We'll review it soon. 👀

Copy link
Contributor

@elitan elitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must wait for nhost/hasura-auth#186 to be released.

@Svarto
Copy link
Contributor Author

Svarto commented Jul 19, 2022

@szilarddoro @elitan just checking back here, the backend hasura-auth PR got released in 0.10.0. Is there a timeline for this to also be released?

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@635d82b). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #679   +/-   ##
=======================================
  Coverage        ?   93.44%           
=======================================
  Files           ?       42           
  Lines           ?     6437           
  Branches        ?      377           
=======================================
  Hits            ?     6015           
  Misses          ?      422           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635d82b...9479aeb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants