-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
included an optional ticket in changePassword function to allow for c… #679
included an optional ticket in changePassword function to allow for c… #679
Conversation
…hangeing password of logged out users, matches hasura-auth nhost#186
🦋 Changeset detectedLatest commit: 53e20e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@Svarto is attempting to deploy a commit to the Nhost Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @Svarto, sorry for not responding to this PR earlier. Your work on this feature is highly appreciated. We'll review it soon. 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must wait for nhost/hasura-auth#186 to be released.
@szilarddoro @elitan just checking back here, the backend hasura-auth PR got released in 0.10.0. Is there a timeline for this to also be released? |
Codecov Report
@@ Coverage Diff @@
## main #679 +/- ##
=======================================
Coverage ? 93.44%
=======================================
Files ? 42
Lines ? 6437
Branches ? 377
=======================================
Hits ? 6015
Misses ? 422
Partials ? 0 Continue to review full report at Codecov.
|
This reverts commit 9479aeb.
This is the nhost-js SDK changes to enable changing password for users that are not logged in but have a valid password reset ticket. See backend
hasura-auth
PR here: hasura-auth #186I believe this should work, I struggled a little as I haven't used the machines that you use to create the request that goes into the backend (looks very impressive, nice work by the way). Have a look and let me know if this would work !