Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Algolia full page search #716

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Fix Algolia full page search #716

merged 3 commits into from
Jun 21, 2022

Conversation

elitan
Copy link
Contributor

@elitan elitan commented Jun 17, 2022 •
edited

Search working both in modal + full page.

Test here: https://docs-git-docs-algolio-fix-nhost.vercel.app/

@elitan elitan requested a review from guicurcio as a code owner June 17, 2022 06:24
@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2022 •
edited

⚠️ No Changeset found

Latest commit: 7f1b8a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 17, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Jun 21, 2022 at 3:21PM (UTC)

@elitan
Copy link
Contributor Author

elitan commented Jun 17, 2022 •
edited

Trying to fix according to: facebook/docusaurus#6693

@elitan elitan changed the title Docs Algolio Fix Algolia full page search Jun 17, 2022
@elitan elitan added the documentation Improvements or additions to documentation label Jun 17, 2022
@elitan elitan mentioned this pull request Jun 17, 2022
Closed
7 tasks
@elitan elitan marked this pull request as draft June 18, 2022 05:56
@elitan elitan linked an issue Jun 21, 2022 that may be closed by this pull request
Documentation search bar is not working #645
Closed
@elitan elitan marked this pull request as ready for review June 21, 2022 15:24
@elitan elitan requested a review from plmercereau June 21, 2022 15:26
@plmercereau
Copy link
Contributor

awesome!

@plmercereau plmercereau merged commit 5f4b16f into main Jun 21, 2022
@plmercereau plmercereau deleted the docs-algolio-fix branch June 21, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plmercereau plmercereau plmercereau approved these changes

@guicurcio guicurcio Awaiting requested review from guicurcio

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation search bar is not working
2 participants
@elitan @plmercereau