Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @nhost/storage-js work on non-browser environments #893

Merged
merged 27 commits into from
Aug 25, 2022

Conversation

elitan
Copy link
Contributor

@elitan elitan commented Aug 23, 2022

No description provided.

@vercel
Copy link

vercel bot commented Aug 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 6:25AM (UTC)
example-react-apollo ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 6:25AM (UTC)
example-vue-apollo ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 6:25AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2022

⚠️ No Changeset found

Latest commit: 6450dcc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #893 (6450dcc) into main (293bdc3) will increase coverage by 3.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
+ Coverage   93.44%   96.65%   +3.21%     
==========================================
  Files          42       39       -3     
  Lines        6437     6076     -361     
  Branches      377      375       -2     
==========================================
- Hits         6015     5873     -142     
+ Misses        422      203     -219     
Impacted Files Coverage Δ
packages/hasura-storage-js/src/machines/index.ts
...a-storage-js/src/machines/multiple-files-upload.ts
...ages/hasura-storage-js/src/machines/file-upload.ts

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@elitan elitan changed the title Make @nhost/storage-js work on server Make @nhost/storage-js work on non-browser environments Aug 23, 2022
@elitan elitan changed the title Make @nhost/storage-js work on non-browser environments [WIP] Make @nhost/storage-js work on non-browser environments Aug 23, 2022
@elitan elitan changed the title [WIP] Make @nhost/storage-js work on non-browser environments Make @nhost/storage-js work on non-browser environments Aug 23, 2022
Copy link
Contributor

@plmercereau plmercereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please

  • add functions/package.json everywhere the nhost cli is used
  • change :1337/v1/auth/healthz to :9695 in other e2e scripts?

For the moment the other e2e tests are not failing because they are cached by turborepo

@elitan elitan merged commit 6ea9ed6 into main Aug 25, 2022
@elitan elitan deleted the fix/storage-in-node branch August 25, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nhost.storage.upload() incompatible with nhost functions.
5 participants