Changed text to put link on the words and removed 'here' #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this based off of #179? As that has some changes that will be in conflict to this (if it’s direct from main) |
|
I've made a change to a vignette, not README so there are no conflicts (I merged locally ok). Shall I leave this until you've done #179? |
|
ah, ok, I thought this change was needed in the readme. PR's are independent then, so I've marked that ready for review and will merge this now. |
tomjemmett
requested changes
Jul 18, 2023
There was a problem hiding this comment.
This text is out of date, I updated the readme in #179 to reflect NHS Improvement no longer existing. I also changed the text to be more concise. I would suggest that we make this document match the "overview" paragraph from the README file
|
Good point! I'll make those changes. |
tomjemmett
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
covr::report()(should aim for 100%)devtools::document()lintr::lint_package()and resolved all lint warnings and notesstyler::style_pkg()to make sure code matches the style guidelines