Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix STU3 URLs #4

Closed
wants to merge 5 commits into from
Closed

Fix STU3 URLs #4

wants to merge 5 commits into from

Conversation

ahatherly
Copy link
Contributor

Hi,
I've updated the resources in quite a few places to correct the STU3 URLs, and also put the actual CodeSystem URLs in - hopefully I've done it all right!
Adam.

@ahatherly ahatherly requested a review from dxh73 September 8, 2017 18:00
@IOPS-DEV
Copy link

Hi Adam,
Couple of things to mention. First, my develop branch was way out of date. I'd gone a bit rouge and updated changes directly on gh-pages branch rather than develop. That said, the problems you fixed still existed on gh-pages. I'll spend some time this morning and get git updated and sync'd up, and make sure I only work on develop branch and merge into gh-pages from now on.

Copy link

@dxh73 dxh73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url for CodeSystem
https://fhir.nhs.uk/STU3/opt-out-source-codesystem-1 with no /CodeSystem/ part.
Removal of element in the CodeSystem.

Spine-OperationOutcome-1 has been removed as it's no longer required.

New example has been created called Consent-Example-1 to replace previous one.

@dxh73
Copy link

dxh73 commented Sep 11, 2017

Hi Adam,

Develop and gh-pages are now sync'd back up. This will have changed the codesystems, valuesets and example. The url structure for codesystem I've left the way we had it, but that's not to say it's the correct way (we're still learning about STU3 changes).

@ahatherly
Copy link
Contributor Author

ahatherly commented Sep 11, 2017 via email

@dxh73
Copy link

dxh73 commented Sep 11, 2017

Hi Adam,
No probs, just the opposite. It's highlighted issues within CS, VS and the example that I'd missed, which shows the importance of a review. I also need to get into the habit of working with git in the right way. A few lessons learned in the project.

@ahatherly ahatherly closed this Jan 29, 2018
@ahatherly ahatherly deleted the fix/stu3urls branch January 29, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants