This repository has been archived by the owner on Jan 15, 2020. It is now read-only.
2️⃣0️⃣ 50 miles is too far to travel #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -0,0 +1 @@ | |||
| { "metersInAMile": 1609 } | |||
There was a problem hiding this comment.
I'd argue that the API should be metric and it is the responsibility of the client to do the necessary conversion.
There was a problem hiding this comment.
Good point, something to change in the future #19
⬇️ Reduce the number of results returned
neilbmclaughlin
approved these changes
Dec 8, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've not done any error checking on the additional variable of how far the search is going to be. The reason for this is that there is currently a duplication in the validation - both the middleware and the lib are doing it. There is no need for this to be the case. I'm going to refactor the duplication out and have the middleware be responsible for validation and setting defaults. Then the lib can concentrate on doing the calculations based on the assumption the inputs are good