New component structure #49

marcofucci · 2017-02-17T15:54:11Z

This:

restructures the components to make them more flexible
tries to improved the wagtail edit form page with some custom style
adds an import form which gets the content from the betahealth app and imports it into the db

Things still to address but probably in separate PRs:

the rashes-in-babies-and-children page contains components to redesign (section_list and section_nav)
the hernia/surgery-guide page contains components to redesign (article_list and article_nav)
the hernia/operation page contains a reveal with a callout which causes circle dependency errors
the API should add a description field and the import script should import the related values from the content folder

Before:

After:

coveralls · 2017-02-17T16:25:15Z

Coverage decreased (-3.2%) to 95.203% when pulling 8b251a6e50c27fa2951f1310f8776e2495276d41 on components-v2 into 8688d87 on master.

r4vi · 2017-02-17T15:57:05Z

home/factories.py

+    class Meta:
+        model = Page
+    #
+    # @classmethod


r4vi · 2017-02-17T17:18:32Z

pages/components/text.py

+    value = RichTextBlock()
+
+    def __init__(self, **kwargs):
+        super(TextBlock, self).__init__(**kwargs)


why not super().__init__(**kwargs)

👍 no reason, still getting used to it.

coveralls · 2017-02-17T18:15:50Z

Coverage decreased (-3.2%) to 95.2% when pulling 27f02dd0b837d4727ff5c2c7d0e9a3dc8eef5c60 on components-v2 into 8688d87 on master.

coveralls · 2017-02-20T15:31:45Z

Coverage decreased (-3.2%) to 95.2% when pulling 4e8f669525561f857eaae51d97e30623861e6f99 on components-v2 into 8688d87 on master.

coveralls · 2017-02-20T15:39:33Z

Coverage decreased (-3.2%) to 95.2% when pulling 5e782d126fa558932c602e6e81d83d015295ec05 on components-v2 into 8688d87 on master.

coveralls · 2017-02-20T16:59:29Z

Coverage decreased (-3.2%) to 95.2% when pulling e2f1ee1c0d28bcb51a609c8eacc1d4e8b17c3800 on components-v2 into 8688d87 on master.

This redesigns the components making them more flexible from a technical point of view.

This does not translate custom markdown (callouts, reveal etc.) into proper components as it would be too fragile.

coveralls · 2017-02-20T17:25:26Z

Coverage decreased (-3.2%) to 95.2% when pulling 3894f3dd2cfcd599e39af3fcb9a01fd1ed17aa60 on components-v2 into 8688d87 on master.

r4vi · 2017-02-21T10:23:26Z

Python is fine, no idea about the other stuff!

tyom · 2017-02-21T10:59:03Z

importer/templates/importer/import_form.html

+{% block content %}
+    {% include "wagtailadmin/shared/header.html" with title="Import content" %}
+
+    <div class="nice-padding">


Is it four or two spaces?

@tyom changed to 4 spaces as it seems to be the convention at Torchbox

teneightfive · 2017-02-21T11:02:32Z

I think this is fine for this major change of restructuring the components and some of the UI but I imagine we'll have to do some more to the UI to reduce the complexity. We're still requiring content designers to think of components as we do whereas they will be thinking in the context of the page and what content appears in a component.

We may want to investigate the idea of presets which are related to a certain content structure like "Do/don't" component which gets rendered as two areas of content and the content store handles sending that out via the API as something like a split_content with two split_areas and possibly a modifier to let the frontend know it needs to render it with the tick and cross lists.

Food for thought...

So that it's easy to move content to our Publishing Tool from our current filesystem strategy. This app is meant to be removed after switching to REST Api rendering only.

This adds a migration to automatically create symptoms and conditions pages if they don't exist in the db already.

coveralls · 2017-02-21T11:16:52Z

Coverage decreased (-3.2%) to 95.2% when pulling cc06ebe on components-v2 into 8688d87 on master.

marcofucci requested review from tyom, r4vi and teneightfive February 17, 2017 15:54

marcofucci force-pushed the components-v2 branch from 7398644 to 8b251a6 Compare February 17, 2017 16:23

r4vi reviewed Feb 17, 2017

View reviewed changes

marcofucci force-pushed the components-v2 branch from 8b251a6 to 27f02dd Compare February 17, 2017 18:14

marcofucci and others added 3 commits February 20, 2017 17:22

Move to a more flexible components structure

37f4383

This redesigns the components making them more flexible from a technical point of view.

Override Wagtail CSS in an attempt to improve UI

f4eb3ec

Add migrations to the new components format

9ceefaf

This does not translate custom markdown (callouts, reveal etc.) into proper components as it would be too fragile.

marcofucci force-pushed the components-v2 branch from e2f1ee1 to 3894f3d Compare February 20, 2017 17:23

r4vi self-requested a review February 21, 2017 10:20

r4vi approved these changes Feb 21, 2017

View reviewed changes

tyom suggested changes Feb 21, 2017

View reviewed changes

teneightfive approved these changes Feb 21, 2017

View reviewed changes

marcofucci added 2 commits February 21, 2017 11:15

Add ability to import content via github

18e7db1

So that it's easy to move content to our Publishing Tool from our current filesystem strategy. This app is meant to be removed after switching to REST Api rendering only.

Create symptoms and conditions pages if necessary

cc06ebe

This adds a migration to automatically create symptoms and conditions pages if they don't exist in the db already.

marcofucci force-pushed the components-v2 branch from 3894f3d to cc06ebe Compare February 21, 2017 11:15

tyom approved these changes Feb 21, 2017

View reviewed changes

marcofucci merged commit 282febe into master Feb 21, 2017

marcofucci deleted the components-v2 branch February 21, 2017 13:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New component structure #49

New component structure #49

marcofucci commented Feb 17, 2017 •

edited

Loading

coveralls commented Feb 17, 2017

r4vi Feb 17, 2017

r4vi Feb 17, 2017

marcofucci Feb 17, 2017

coveralls commented Feb 17, 2017

coveralls commented Feb 20, 2017

coveralls commented Feb 20, 2017

coveralls commented Feb 20, 2017

coveralls commented Feb 20, 2017

r4vi commented Feb 21, 2017

tyom Feb 21, 2017

marcofucci Feb 21, 2017

teneightfive commented Feb 21, 2017

coveralls commented Feb 21, 2017

New component structure #49

New component structure #49

Conversation

marcofucci commented Feb 17, 2017 • edited Loading

coveralls commented Feb 17, 2017

r4vi Feb 17, 2017

Choose a reason for hiding this comment

r4vi Feb 17, 2017

Choose a reason for hiding this comment

marcofucci Feb 17, 2017

Choose a reason for hiding this comment

coveralls commented Feb 17, 2017

coveralls commented Feb 20, 2017

coveralls commented Feb 20, 2017

coveralls commented Feb 20, 2017

coveralls commented Feb 20, 2017

r4vi commented Feb 21, 2017

tyom Feb 21, 2017

Choose a reason for hiding this comment

marcofucci Feb 21, 2017

Choose a reason for hiding this comment

teneightfive commented Feb 21, 2017

coveralls commented Feb 21, 2017

marcofucci commented Feb 17, 2017 •

edited

Loading