Skip to content
This repository has been archived by the owner on Jun 20, 2018. It is now read-only.

WIP: Docker config #61

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

adamgraves-choices
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Mar 8, 2017

Coverage Status

Coverage remained the same at 94.543% when pulling f0e5fbb on feature/docker-config into f9ca294 on master.

},
}

DEBUG = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might forget to change this to False in the future.

Could we do this instead
DEBUG = os.environ.get('DEBUG', '0') == '1'
and use an env var DEBUG = '1' in prod instead when needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible idea, done.

DEBUG = False
import os

ALLOWED_HOSTS = ['*']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make a note that we need to change this to not using * if we don't know yet what should go there.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this to use a ENV var and strip it on commas.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.608% when pulling baf0a85 on feature/docker-config into 9fd4b8e on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 94.486% when pulling 1eed012 on feature/docker-config into 9fd4b8e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.486% when pulling fd4cf96 on feature/docker-config into a96e3e5 on master.

@coveralls
Copy link

coveralls commented Mar 15, 2017

Coverage Status

Coverage remained the same at 94.486% when pulling dd4111f on feature/docker-config into a96e3e5 on master.

@coveralls
Copy link

coveralls commented Apr 5, 2017

Coverage Status

Coverage remained the same at 94.486% when pulling 13c702a on feature/docker-config into a96e3e5 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.486% when pulling a3a0cb0 on feature/docker-config into a96e3e5 on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants