WIP: Docker config #61
base: master
Are you sure you want to change the base?
Conversation
nhsuk/settings/production.py
Outdated
}, | ||
} | ||
|
||
DEBUG = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might forget to change this to False in the future.
Could we do this instead
DEBUG = os.environ.get('DEBUG', '0') == '1'
and use an env var DEBUG = '1'
in prod instead when needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sensible idea, done.
nhsuk/settings/production.py
Outdated
DEBUG = False | ||
import os | ||
|
||
ALLOWED_HOSTS = ['*'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make a note that we need to change this to not using *
if we don't know yet what should go there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this to use a ENV var and strip it on commas.
f0e5fbb
to
baf0a85
Compare
fd4cf96
to
dd4111f
Compare
No description provided.