[refs #160] Change the way triangle is generated in care cards #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhunter08
approved these changes
Dec 3, 2018
chrimesdev
force-pushed
the
accessibility/care-cards
branch
2 times, most recently
from
1dbd16a
to
dfebb8a
Compare
Using the clip path method for generating the care card triangles makes it not show up in High Contrast Mode in Windows. This was picked up in a DAC report. Despite looking at a gov.uk blog post on this (https://accessibility.blog.gov.uk/2018/08/01/supporting-users-who-change-colours-on-gov-uk/) it still didn't seem to work in High Contrast Mode, so it has been changed to borders and transforms, inspired from https://codepen.io/mpeace/pres/eBOVGe
chrimesdev
force-pushed
the
accessibility/care-cards
branch
from
dfebb8a
to
77dfdcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the clip path method for generating the care card triangles makes
it not show up in High Contrast Mode in Windows. This was picked up in a
DAC report. Despite looking at a gov.uk blog post on this
(https://accessibility.blog.gov.uk/2018/08/01/supporting-users-who-change-colours-on-gov-uk/)
it still didn't seem to work in High Contrast Mode, so it has been
changed to borders and transforms, inspired from
https://codepen.io/mpeace/pres/eBOVGe
Component checklist