[refs #107] Fix feedback banner JS to prevent console errors #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrimesdev
force-pushed
the
bug/feedback-banner-js-error
branch
from
d0ee4b2
to
5f37c21
Compare
If the feedback banner element did not exist on the page, the JavaScript console in browsers would throw an error when users were scrolling down the page because it couldn't find that element.
chrimesdev
force-pushed
the
bug/feedback-banner-js-error
branch
from
5f37c21
to
8103ed8
Compare
mcheung-nhs
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the feedback banner element did not exist on the page, the JavaScript console in browsers would throw an error when users were scrolling down the page because it couldn't find that element.