[STAN-557] Search and Filter fixes #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe an integration test? |
Ugh that is so incredibly reasonable! |
|
The same bug also affects searching from the header bar on other pages too, so you may wish to also cover that. |
sigh yes |
lennym
reviewed
May 17, 2022
| .summary { | ||
| border: 10px solid yellow; | ||
| &:before { | ||
| border: 10px solid lime !important; |
roc
changed the title
lennym
reviewed
May 17, 2022
| // TODO: better sorting needed | ||
| const activeFilters = standard_category | ||
| ? { ...chosenFilters, standard_category } | ||
| : chosenFilters; |
There was a problem hiding this comment.
Rather than forcing the ordering so that category is at the end (but leaving care setting and topic potentially misordered), it feels probably better to just iterate over a fixed set of keys like we do (indirectly) here.
There was a problem hiding this comment.
Agree, leaving a TODO in my branch to pick this up after merge->deploy->demo etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"", bringing back all results)Filter updates
Type(we write "in" for that)
* expander icons aligned with headings
* When clicking "mandated" alone we no longer get two lines across the filter summary sectionbefore
after